718474 - Changes to zoom.maxPercent require restart

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[ACHeron]

1. Open about:config and increase zoom.maxPercent above your current limit, e.g. from default 300 to 500.
2. Try to zoom any webpage above 300% by pressing Ctrl-+. -- Zooming stops at 300%.
3. Try to zoom any webpage above 300% by holding Ctrl and scrolling a mouse wheel. -- The page is briefly zoomed to above 300%, but is quickly reverted to 300%. 

If you quit Firefox and start it again, the limit is changed correctly.

Comment 1

[ACHeron]

Also it works correctly for images.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 718474 - allow changing zoom values, min and max, at runtime, r?morgan

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74ef7968d60e
allow changing zoom values, min and max, at runtime, r=morgan

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/74ef7968d60e

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I was able to reproduce this issue on Firefox 98(20220304153049) on Win10 64-bit using the steps from the Description. The issue is partly resolved(zooming with Ctrl+Mouse Wheel behaves as expected), however, keyboard scrolling is still faulty on Firefox 100.0b7(20220417185951) and Nightly 101.0a1(20220419093010). It will not go above the maximum zoom level before the tweaks in about:config.(In newer version of Firefox the default zoom value is 500; I changed it to 700, restarted the browser and tried to zoom in without success). Also, if one zooms in using Ctrl+Mouse Wheel above a 500 value, and tries to zoom out using the keyboard, the value will downgrade directly to 400.
I'm leaving a recording of the keyboard scroll on Fx 100 here.
On macOS 11 and Ubuntu 20 the same behaviour is enconteured - mouse zooming is working as expected, but keyboard zooming is not.
Should I re-open this bug or fill a new one strictly related to the keybooard zoom issue?
Thank you in advance.

Comment 6

[:Gijs (he/him)]

(In reply to Ardelean Oana from comment #5)

I was able to reproduce this issue on Firefox 98(20220304153049) on Win10 64-bit using the steps from the Description. The issue is partly resolved(zooming with Ctrl+Mouse Wheel behaves as expected), however, keyboard scrolling is still faulty on Firefox 100.0b7(20220417185951) and Nightly 101.0a1(20220419093010). It will not go above the maximum zoom level before the tweaks in about:config.(In newer version of Firefox the default zoom value is 500; I changed it to 700, restarted the browser and tried to zoom in without success). Also, if one zooms in using Ctrl+Mouse Wheel above a 500 value, and tries to zoom out using the keyboard, the value will downgrade directly to 400.
I'm leaving a recording of the keyboard scroll on Fx 100 here.
On macOS 11 and Ubuntu 20 the same behaviour is enconteured - mouse zooming is working as expected, but keyboard zooming is not.
Should I re-open this bug or fill a new one strictly related to the keybooard zoom issue?
Thank you in advance.

You would have to also change toolkit.zoomManager.zoomValues, which is a comma separated list of zoom values (divided by 100, so .3 is 30%, and 5 is 500% - you'd want to add values (like ,6,7) to the end to confirm zooming to 700 or w/e works. Can you re-test with that and confirm it works?

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you for you answer! I can confirm that after changing the toolkit.zoomManager.zoomValues pref - adding 6,7 values - it works as expected with both mouse and keyboard zooming. Re-tested on Firefox 100.0(20220428192727) and Nightly 101.0a1(20220428214715) on macOS 11, Win10 64-bits and Ubuntu 20.04, verified as fixed.