718488 - calDateTime doesn't need to implement nsIXPCScriptable

Status: RESOLVED FIXED

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

calDateTime implements nsIXPCScriptable just so it can have a jsval attribute; this can now be done directly in IDL with lots less hassle.

From code inspection, also fixes a crash under js_DateIsValid if setting jsDate to null. (JSVAL_IS_OBJECT, unlike JS::Value::isObject, returns true for null, and js_DateIsValid expects a non-null argument.)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Pushed to try as well: <http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&pusher=[e-mail]>. No idea if it's supposed to look as much like a Christmas tree as it does.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 588951 [details] [diff] [review]
Patch v1

Review of attachment 588951 [details] [diff] [review]:
-----------------------------------------------------------------

Great, glad to get rid of this! Calendar isn't quite as strict regarding try builds, so if you like go ahead and push this any time. If something turns out to be red we can always fix it afterwards.

r=philipp

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/comm-central/rev/322e17039385