Closed Bug 718488 Opened 9 years ago Closed 9 years ago

calDateTime doesn't need to implement nsIXPCScriptable

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
8.32 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
calDateTime implements nsIXPCScriptable just so it can have a jsval attribute; this can now be done directly in IDL with lots less hassle.

From code inspection, also fixes a crash under js_DateIsValid if setting jsDate to null. (JSVAL_IS_OBJECT, unlike JS::Value::isObject, returns true for null, and js_DateIsValid expects a non-null argument.)
Attachment #588951 - Flags: review?(philipp)
Pushed to try as well: <http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&pusher=Ms2ger@gmail.com>. No idea if it's supposed to look as much like a Christmas tree as it does.
Comment on attachment 588951 [details] [diff] [review]
Patch v1

Review of attachment 588951 [details] [diff] [review]:
-----------------------------------------------------------------

Great, glad to get rid of this! Calendar isn't quite as strict regarding try builds, so if you like go ahead and push this any time. If something turns out to be red we can always fix it afterwards.

r=philipp
Attachment #588951 - Flags: review?(philipp) → review+
https://hg.mozilla.org/comm-central/rev/322e17039385
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.