Make sure SDKROOT/python-lib/cuddlefish/templates.py is reporting the correct license

RESOLVED FIXED in 1.6

Status

P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: KWierso, Assigned: warner)

Tracking

unspecified
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
When I look at a Jetpack addon's harness-options.json, addon-kit, api-utils, and my own module's license information still lists the tri-license, even though bug 715558 changed Jetpack's modules to use MPL2.

I think templates.py's PACKAGE_JSON template needs to be changed for this to be fixed, yes?
(Reporter)

Updated

7 years ago
Assignee: nobody → warner-bugzilla
Priority: -- → P1
(Reporter)

Updated

7 years ago
Depends on: 715558
(Assignee)

Comment 1

7 years ago
Created attachment 593273 [details] [diff] [review]
change default package.json license field to MPL2.0

Patch 1 of 2. This changes the templates.py license field, which is used when "cfx init" creates a skeleton addon (and is therefore the default license we're encouraging SDK users to use). Cc'ing dcm so he's aware of the change (this is kind of pushing MPL2 on developers).

Next patch will update the license fields in the the dozen-ish package.jsons scattered around the SDK, including the stdlib ones (api-utils, addon-kit, and examples).
Attachment #593273 - Flags: review?(rFobic)
Attachment #593273 - Flags: feedback?(dcm)
(Assignee)

Comment 2

7 years ago
Created attachment 593274 [details] [diff] [review]
change stdlib/examples package.json licenses to MPL2.0

and this updates all the package.jsons in the SDK, such as the stdlib packages and examples.
Attachment #593274 - Flags: review?(rFobic)
Attachment #593274 - Flags: feedback?(dcm)
Attachment #593274 - Flags: review?(rFobic) → review+
Attachment #593273 - Flags: review?(rFobic) → review+
This looks good to me as well - I don't have any issues in pushing the MPL2 on add-on devs as it truly is an easier to understand license, as well as one that plays better with other licenses. It should be a win for everyone.
Attachment #593274 - Flags: feedback?(dcm) → feedback+
Attachment #593273 - Flags: feedback?(dcm) → feedback+

Comment 4

7 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fd62ad2448cbf53abcc3212ddea0b413be803cf2
Bug 718497: update package.json and templates.py to use MPL2.0. r=@gozala
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.