Closed Bug 718589 Opened 12 years ago Closed 10 years ago

[cs] Search engine setup for Thunderbird

Categories

(Mozilla Localizations :: cs / Czech, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: JasnaPaka)

References

()

Details

(Keywords: productization)

Attachments

(1 file, 2 obsolete files)

For Czech you currently have landed a copy of the en-US search engines in your locale, which is incorrect. In future, you should also get permission (by filing a productization bug) for changes to mail/searchplugins.

Please can you initially remove all the xml files in the mail/searchplugins directory from aurora & beta, and then request sign-off for the beta as we're short on time for TB 10.

Once you've done that, I'll detail more about localising the search plugins.
Assignee: p.franc → pcvrcek
Status: NEW → ASSIGNED
Attached patch tip.patch (obsolete) — Splinter Review
List of search plugins for Thunderbird. It is the same list which we have for Firefox. Only one difference is removing "<Param name="sourceid" value="firefox"/>" based on your words in Bug 714244.
Attachment #8343905 - Flags: review?(mbanner)
Does bing support cs?
(In reply to Mark Banner (:standard8) (away until 3 Jan) from comment #4)
> Does bing support cs?

Bing is translated into Czech language, yes. Does it mean you would like to see Bing instead of one from the existing search plugins?
Flags: needinfo?(mbanner)
Would you be able to keep bing as #3 option? (as it is now?)
Flags: needinfo?(mbanner)
Attached patch Patch v2 (obsolete) — Splinter Review
List of search plugins is the same like czech version of Firefox has. Because Thunderbird distributes 8 search plugins by default (Firefox has 6) we use Bing (as Mark wants) and Twitter too.
Attachment #8343905 - Attachment is obsolete: true
Attachment #8343905 - Flags: review?(mbanner)
Attachment #8376836 - Flags: review?(mbanner)
Attachment #8376836 - Flags: feedback?(francesco.lodolo)
Attached patch Patch v3Splinter Review
Sorry, wrong patch. Now it is better.
Attachment #8376836 - Attachment is obsolete: true
Attachment #8376836 - Flags: review?(mbanner)
Attachment #8376836 - Flags: feedback?(francesco.lodolo)
Attachment #8376837 - Flags: review?(mbanner)
Attachment #8376837 - Flags: feedback?(francesco.lodolo)
I see you removed utm_source in heureka-cz.xml and sourceid in seznam-cz.xml. It would be nice to understand if they want different values instead of dropping the parameter entirely (or maybe you already did that).
I removed utm_source because this information: https://bugzilla.mozilla.org/show_bug.cgi?id=714244#c7.
Comment on attachment 8376837 [details] [diff] [review]
Patch v3

Review of attachment 8376837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good then, even if I personally prefer them in alphabetical order in list.txt
Attachment #8376837 - Flags: feedback?(francesco.lodolo) → feedback+
Attachment #8376837 - Flags: review?(mbanner) → review+
http://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/33835e88dabc
http://hg.mozilla.org/l10n-central/cs/rev/cfaa283f77c4

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: