Last Comment Bug 718617 - ObserverList provided by ipc/chromium conflicts with mozilla::ObserverList
: ObserverList provided by ipc/chromium conflicts with mozilla::ObserverList
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: mozilla12
Assigned To: Thinker Li [:sinker] PTO during Sep 22 ~ 30
:
Mentors:
Depends on:
Blocks: 697641
  Show dependency treegraph
 
Reported: 2012-01-17 05:37 PST by Thinker Li [:sinker] PTO during Sep 22 ~ 30
Modified: 2012-01-30 02:54 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move ObserverList of chromium into namespace "base" (6.37 KB, patch)
2012-01-17 05:41 PST, Thinker Li [:sinker] PTO during Sep 22 ~ 30
benjamin: review+
Details | Diff | Splinter Review

Description Thinker Li [:sinker] PTO during Sep 22 ~ 30 2012-01-17 05:37:32 PST
There is a conflict between mozilla::ObserverList and ObserverList defined by ipc/chromium if some one use mozilla::ObserverList with headers generated by ipdl.  This conflict only appears for Windows platforms.  I guess it is about implementation of windows compiler.  To avoid conflicts, we can move ObserverList defined by ipc/chromium to namespace "base", likes other symbols introduced the same directory.

Following URL is an error log when it is happening.
https://tbpl.mozilla.org/php/getParsedLog.php?id=8526382&tree=Try&full=1#error0
Comment 1 Thinker Li [:sinker] PTO during Sep 22 ~ 30 2012-01-17 05:41:42 PST
Created attachment 589160 [details] [diff] [review]
Move ObserverList of chromium into namespace "base"
Comment 2 Mozilla RelEng Bot 2012-01-26 01:00:34 PST
Try run for e4e8b81ececc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=e4e8b81ececc
Results (out of 208 total builds):
    exception: 1
    success: 186
    warnings: 20
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/tlee@mozilla.com-e4e8b81ececc
Comment 4 Marco Bonardo [::mak] 2012-01-30 02:54:56 PST
https://hg.mozilla.org/mozilla-central/rev/4d85f4ff7145

Note You need to log in before you can comment on or make changes to this bug.