The default bug view has changed. See this FAQ.

ObserverList provided by ipc/chromium conflicts with mozilla::ObserverList

RESOLVED FIXED in mozilla12

Status

()

Core
IPC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sinker, Assigned: sinker)

Tracking

Trunk
mozilla12
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There is a conflict between mozilla::ObserverList and ObserverList defined by ipc/chromium if some one use mozilla::ObserverList with headers generated by ipdl.  This conflict only appears for Windows platforms.  I guess it is about implementation of windows compiler.  To avoid conflicts, we can move ObserverList defined by ipc/chromium to namespace "base", likes other symbols introduced the same directory.

Following URL is an error log when it is happening.
https://tbpl.mozilla.org/php/getParsedLog.php?id=8526382&tree=Try&full=1#error0
(Assignee)

Comment 1

5 years ago
Created attachment 589160 [details] [diff] [review]
Move ObserverList of chromium into namespace "base"
(Assignee)

Updated

5 years ago
Blocks: 697641
(Assignee)

Updated

5 years ago
Attachment #589160 - Flags: review?(benjamin)
Attachment #589160 - Flags: review?(benjamin) → review+

Comment 2

5 years ago
Try run for e4e8b81ececc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=e4e8b81ececc
Results (out of 208 total builds):
    exception: 1
    success: 186
    warnings: 20
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/tlee@mozilla.com-e4e8b81ececc
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Assignee: nobody → thinker
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d85f4ff7145
Keywords: checkin-needed
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/4d85f4ff7145
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.