Closed Bug 718617 Opened 11 years ago Closed 11 years ago

ObserverList provided by ipc/chromium conflicts with mozilla::ObserverList

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: sinker, Assigned: sinker)

References

Details

Attachments

(1 file)

Move ObserverList of chromium into namespace "base"
6.37 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
There is a conflict between mozilla::ObserverList and ObserverList defined by ipc/chromium if some one use mozilla::ObserverList with headers generated by ipdl.  This conflict only appears for Windows platforms.  I guess it is about implementation of windows compiler.  To avoid conflicts, we can move ObserverList defined by ipc/chromium to namespace "base", likes other symbols introduced the same directory.

Following URL is an error log when it is happening.
https://tbpl.mozilla.org/php/getParsedLog.php?id=8526382&tree=Try&full=1#error0
Blocks: 697641
Attachment #589160 - Flags: review?(benjamin)
Attachment #589160 - Flags: review?(benjamin) → review+
Try run for e4e8b81ececc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=e4e8b81ececc
Results (out of 208 total builds):
    exception: 1
    success: 186
    warnings: 20
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/tlee@mozilla.com-e4e8b81ececc
Keywords: checkin-needed
Assignee: nobody → thinker
https://hg.mozilla.org/mozilla-central/rev/4d85f4ff7145
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.