Closed Bug 718640 Opened 9 years ago Closed 9 years ago

Account Provisioner link to view providers in other languages is always displayed

Categories

(Thunderbird :: Mail Window Front End, defect)

10 Branch
x86
All
defect
Not set
normal

Tracking

(thunderbird11 fixed)

RESOLVED FIXED
Thunderbird 12.0
Tracking Status
thunderbird11 --- fixed

People

(Reporter: mconley, Assigned: mconley)

Details

Attachments

(1 file)

We display the link that allows users to choose providers in languages other than their own, even when no providers exist.

I noticed this after Sancus removed the fake Yandex entry from the provider list.
Attached patch Patch v1Splinter Review
It looks like at some point we switched the div from being named "otherLanguages" to "otherLangDesc", and so the display:none; CSS property was never applied.

I've also added a regression test.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #589185 - Flags: review?(bwinton)
Comment on attachment 589185 [details] [diff] [review]
Patch v1

Review of attachment 589185 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good and nice catch!

r=me.
Attachment #589185 - Flags: review?(bwinton) → review+
Attachment #589185 - Flags: approval-comm-aurora?
Attachment #589185 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/221b010fd6a1

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/de5589a5f7fb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.