71865 - Replying to msg with attachment displayed shows content type

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Sheela Ravindran]

Buildid:  2001-03-12-09 on win98
Replying to a message that has an attachment reveals the content type and 
content encoding in the compose window as well when the message is received.
Steps to reproduce:
Have reply to messages inline selected in the preference. 
Have the html compose window checked in accounts and settings.
compose a new message and attach a jpeg file to yourself
Receive the message
Reply to the message that you just received. 

Actual: You will see that when the compose window comes up displaying the image 
inline and if you scroll down you will also see the content type and content 
encoding in the message body.  This information is further revealed when you 
receive this message.

Expected: Image displayed inline in the compose window and no content type and 
content encoding information displayed in the message body while replying or 
after receiving the message.

I am not able to check this on mac and linux because of bug 70928.

Comment 1

[Sheela Ravindran]

changing the component.  Nominating this bug so that this can get fixed.  This 
information only shown in headers or in 4.x when you click on the attachment and 
right click to see the attachment properties.  This could have been a 
regression too.  

Comment 2

[(not reading, please use [e-mail] instead)]

compose -> ducarroz.

Comment 3

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9.1

Comment 4

[Jean-Francois Ducarroz]

If I send the message first with 4.x, I can reply to it without having the
content type showing. Looks like a send problem

Comment 5

[Sheela Ravindran]

change qa contact to myself, adding keywords crash to this bug and changed the 
severity because of crashing. changed the summary of the bug.

buildid:2001-04-11-06 on win98.  Now When I reply to a message with an 
attachment (gif icon) displayed inline I crash.  Below is the stack trace: And 
the incident id if you need more information -29013637 
nsImageFrame::AttributeChanged 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsImageFrame.cpp, line 1498] 
nsCSSFrameConstructor::AttributeChanged 
[d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp, 
line 9879] 
StyleSetImpl::AttributeChanged 
[d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1272] 
PresShell::AttributeChanged 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 4520] 
nsDocument::AttributeChanged 
[d:\builds\seamonkey\mozilla\content\base\src\nsDocument.cpp, line 1692] 
nsHTMLDocument::AttributeChanged 
[d:\builds\seamonkey\mozilla\content\html\document\src\nsHTMLDocument.cpp, line 
1378] 
nsGenericHTMLElement::SetAttribute 
[d:\builds\seamonkey\mozilla\content\html\content\src\nsGenericHTMLElement.cpp, 
line 1415] 
nsHTMLImageElement::SetSrcInner 
[d:\builds\seamonkey\mozilla\content\html\content\src\nsHTMLImageElement.cpp, 
line 1078] 
nsHTMLImageElement::SetSrc 
[d:\builds\seamonkey\mozilla\content\html\content\src\nsHTMLImageElement.cpp, 
line 1186] 
nsMsgComposeAndSend::ProcessMultipartRelated 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 1660] 
nsMsgComposeAndSend::HackAttachments 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 2150] 
nsMsgComposeAndSend::Init 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 2631] 
nsMsgComposeAndSend::CreateAndSendMessage 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgSend.cpp, line 3510] 
nsMsgCompose::_SendMsg 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgCompose.cpp, line 607] 
nsMsgCompose::SendMsg 
[d:\builds\seamonkey\mozilla\mailnews\compose\src\nsMsgCompose.cpp, line 692] 
XPTC_InvokeByIndex 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, 
line 139] 
nsXPCWrappedNativeClass::CallWrappedMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativeclass.cpp, 
line 937]

WrappedNative_CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, 
line 245] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 815] 
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2707] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 831] 
nsXPCWrappedJSClass::CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappedjsclass.cpp, line 
876] 
nsXPCWrappedJS::CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappedjs.cpp, line 432] 
PrepareAndDispatch 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp, 
line 102] 
SharedStub 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp, 
line 124] 
XPTC_InvokeByIndex 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, 
line 139] 
nsXPCWrappedNativeClass::CallWrappedMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativeclass.cpp, 
line 937]

WrappedNative_CallMethod 
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, 
line 245] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 815] 
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2707] 
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 831] 
js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 903] 
JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3342] 
nsJSContext::CallEventHandler 
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 943] 
nsJSEventListener::HandleEvent 
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 155] 
nsEventListenerManager::HandleEventSubType 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 
921] 
nsEventListenerManager::HandleEvent 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line 
1855] 
nsXULElement::HandleDOMEvent 
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 
3673] 
PresShell::HandleDOMEventWithTarget 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5264] 
nsButtonBoxFrame::MouseClicked 
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 181] 
nsButtonBoxFrame::HandleEvent 
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 128] 
PresShell::HandleEventInternal 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5233] 
PresShell::HandleEventWithTarget 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5188] 
nsEventStateManager::CheckForAndDispatchClick 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 
2292] 
nsEventStateManager::PostHandleEvent 
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 
1392] 
PresShell::HandleEventInternal 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5237] 
PresShell::HandleEvent 
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5143] 
nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 377] 
nsViewManager::DispatchEvent 
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 2001] 
HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 68] 
nsWindow::DispatchEvent 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 699] 
nsWindow::DispatchWindowEvent 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 716] 
nsWindow::DispatchMouseEvent 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4020] 
ChildWindow::DispatchMouseEvent 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4263] 
nsWindow::ProcessMessage 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3029] 
nsWindow::WindowProc 
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 951] 
KERNEL32.DLL + 0x363b (0xbff7363b) 
KERNEL32.DLL + 0x24407 (0xbff94407) 
0x00688b5a  

Comment 6

[scottputterman]

moving to 0.9.2 and removing crash keyword because the crash is a dup of a
different bug that I think has been fixed.

Comment 7

[Jean-Francois Ducarroz]

Attachment: Proposed fix, V1

Comment 8

[scottputterman]

moving to 0.9.3

Comment 9

[scottputterman]

oops. missed the Have Fix.

Comment 10

[Jean-Francois Ducarroz]

This fix cause a regression: We are not putting a separator before an inline message/rfc822 attachment. This is due 
to the following change I did by accident:

@@ -160,6 +158,4 @@
     return nsMimeBaseEmitter::WriteHTMLHeaders();
   }
-  else
-    mFirstHeaders = PR_FALSE;

Comment 11

[Jean-Francois Ducarroz]

Attachment: proposed fix, V2

Comment 12

[scottputterman]

moving to 0.9.4

Comment 13

[scottputterman]

moving to 0.9.5

Comment 14

[varada]

Applied patch and reviewed.
r=varada

Comment 15

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 16

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 17

[Sheela Ravindran]

verified using builds below:
2001-08-13-06 win98
2001-08-13-04 mac
2001-08-13-06 linux

Comment 18

[Ben Bucksch (:BenB)]

The fix for this bug caused regression bug 134492. I'm now looking into how to
fix this bug another way, if necessary.

Comment 19

[Ben Bucksch (:BenB)]

I think I have a fix, please see the other bug for more info and further updates.