718725 - services.user doesn't accept "check_node" argument

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[:Atoll]

Please port the check_node argument from services.auth to services.user, as it's mandatory for load testing (where we set it to false).

Comment 1

[Ryan Kelly [:rfkelly]]

After further investigation, it looks like no special support in services.user should be necessary.  The code in wsgiauth.py checks for "auth.check_node" directly in the config rather than looking for it as an attribute of the services.user backend object.

What happens when you set auth.check_node in the config file for a services.user backend?  Does it give an error, or just not work?

I will attach a testcase for auth.check_node, which passes for me under both services.auth and services.user on current tip.

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: simple test case for auth.check_node functionality

Comment 3

[Ryan Kelly [:rfkelly]]

We don't plan to deploy anything of updated server-core, but still, there's a reviewed patch here so I might as well commit it.

http://hg.mozilla.org/services/server-core/rev/27768497bc68

Comment 4

[James Bonacci [:jbonacci]]

Yea verified the test on sync 1.1:
./sync/server-full/deps/server-core/services/tests/test_wsgiauth.py

For completeness Verifying the ticket.