EXCEPTION: Timeout waiting for modal dialog to open.
at: utils.js line 429
TimeoutError("Timeout waiting for modal dialog to open.") utils.js 429
waitFor((function () this.waitingForOpen == null && this.monitorizeClose()),"Timeout waiting for modal dialog to open.",10000,100,[object Object]) utils.js 467
WindowWatcher_waitForModalDialog("Addons:Install",(void 0)) test-window-helpers.js 398
wait_for_modal_dialog("Addons:Install") test-window-helpers.js 631
test_install_xpi_offer() test-install-xpi.js 158
Created attachment 589284 [details] [diff] [review]
This has been happening randomly for a while but has just got a lot worse, I thought there was a bug filed but apparently not.
As it happens, the cause is AMO having a few issues (according to the status page), which is the perfect opportunity to debug. It appears that when we install an add-on there's a ping in to the cache to check for compatibility updates.
There's a pref that we can use to turn this off - extensions.getAddons.cache.enabled.
Doing an export NSPR_LOG_MODULES=nsHttp:5 and grepping the log, with the pref as its default, I was seeing "Host: services.addons.mozilla.org", but with the pref turned off, there's no such line.
This should prevent our tests failing when there's no amo.
Comment on attachment 589284 [details] [diff] [review]
Solid patch - looks good to me. All content-tabs tests are passing locally.
I don't think we test add-ons elsewhere, so I assume the rest of the tests are fine. r=me.
Checked in: http://hg.mozilla.org/comm-central/rev/72e27df65c84
Checked into branches: