Last Comment Bug 718850 - IonMonkey: JSOP_AND cannot be used in loops.
: IonMonkey: JSOP_AND cannot be used in loops.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Sean Stangl [:sstangl]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-17 15:13 PST by Sean Stangl [:sstangl]
Modified: 2012-01-18 11:35 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix bogus stackDepth() assertions. (1.95 KB, patch)
2012-01-17 16:41 PST, Sean Stangl [:sstangl]
jdemooij: review+
Details | Diff | Splinter Review

Description Sean Stangl [:sstangl] 2012-01-17 15:13:11 PST
We currently fail to compile the following script:

> function f() {
> 	var i = 1;
> 	while (i && 1 == 1)
> 	{ }
> }
> 
> f();

The IonBuilder assumes that both sides of the && have a common join point, which is only useful for code like |var x 1 && 7;|.

This bug is preventing us from running v8's crypto test.
Comment 1 Sean Stangl [:sstangl] 2012-01-17 16:41:50 PST
Created attachment 589348 [details] [diff] [review]
Fix bogus stackDepth() assertions.
Comment 2 Sean Stangl [:sstangl] 2012-01-18 11:35:37 PST
http://hg.mozilla.org/projects/ionmonkey/rev/49bc8d35a21e

Note You need to log in before you can comment on or make changes to this bug.