718897 - add get_light to lights.h and liblights.cpp

Status: RESOLVED WONTFIX

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Jim Straus]

liblights doesn't currently provide and abstract way to get the state of the lights to correspond to get_lights.  This bug adds that functionality.

Comment 1

[Jim Straus]

This would require our partners to enhance their libhardware to support the extended functionality.  If it is accepted, revisit bug 712378 and define HAVEGETLIGHT.

Comment 2

[Jim Straus]

Attachment: Change to sample liblights

Comment 3

[Jim Straus]

Attachment: Changes to the sample liblights

Comment 4

[Justin Dolske [:Dolske]]

This patch didn't have a specific reviewer tagged; looking at other patches in this component [e-mail] seems a common review (along with cjones?). Feel free to reassign review as needed.

Comment 5

[Justin Lebar (not reading bugmail)]

> This would require our partners to enhance their libhardware to support the extended 
> functionality.

Specifically, assuming HAVEGETLIGHT would require that our partners enhance their libraries, right?

I don't think I'm the right reviewer here for this Linux-y stuff.

Comment 6

[Michael Wu [:mwu]]

I don't see the point. Why not just cache the last value set for the light? We support a number of devices right now and modifying all of them to support this API seems unnecessary extra work. This also makes it more difficult to support devices where we don't have access to the source of the lights module.

Comment 7

[Justin Lebar (not reading bugmail)]

> Why not just cache the last value set for the light?

AIUI that's what we do now in bug 712378.

Comment 8

[Michael Wu [:mwu]]

(In reply to Justin Lebar [:jlebar] from comment #7)
> > Why not just cache the last value set for the light?
> 
> AIUI that's what we do now in bug 712378.

Great. No need for this then.