Can't approve your own revision

VERIFIED FIXED in 2012-01-24

Status

VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: verdi, Assigned: rrosario)

Tracking

unspecified
2012-01-24

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=contributor c=wiki s=2012.2 p=1 post-sprint)

(Reporter)

Description

7 years ago
It appears that when you approve your own revision, a comment to the editor is required but a comment form is not displayed. So when you click approve you are taken back to the original review screen.

In the case of approving your own revision where you are the only editor, a comment shouldn't be required.
(Assignee)

Comment 1

7 years ago
I am pretty sure this is fixed on master and we can cherry-pick a commit or apply part of it.
Assignee: nobody → rrosario
Whiteboard: u=contributor c=wiki s=2012.2 p=1
Target Milestone: --- → 2012-01-24
(Assignee)

Comment 2

7 years ago
Yeah, this is fixed on master. I cherry-picked the commit to next for hot-fixing:

https://github.com/mozilla/kitsune/commit/c9b89caac6ba60b8e4567f76278a4abc70dff738
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Verified able to approve your own revision, no comment box but the approval radio buttons display and the edit is submitted correctly [user is not returned to original review screen.]
Status: RESOLVED → VERIFIED
(Assignee)

Updated

7 years ago
Whiteboard: u=contributor c=wiki s=2012.2 p=1 → u=contributor c=wiki s=2012.2 p=1 post-sprint
You need to log in before you can comment on or make changes to this bug.