Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

RESOLVED FIXED in mozilla12

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: johns, Assigned: johns)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 589370 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

Per discussion in #jsapi
Assignee: nobody → jschoenick
Status: NEW → ASSIGNED
Attachment #589370 - Flags: review?(anygregor)
Blocks: 704646
Comment on attachment 589370 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

>@@ -3622,35 +3630,47 @@ class PreciseGCRunnable : public nsRunna
>         JSContext *cx;
>         JSContext *iter = nsnull;
>         while ((cx = JS_ContextIterator(rt, &iter)) != NULL) {
>             if (JS_IsRunning(cx)) {
>                 return NS_DispatchToMainThread(this);
>             }
>         }
> 
>-        JS_GC(mCx);
>+        if (mShrinking)
>+          JS_ShrinkingGC(mCx);
>+        else
>+          JS_GC(mCx);

Looks like the indentation should be 4 here.
Attachment #589370 - Flags: review?(anygregor) → review+
Is there any reason to make the argument to PreciseGCRunnable optional?
(Assignee)

Comment 4

6 years ago
Created attachment 589921 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

@Ms2ger - Not particularly, its only a helper class in this file. Changed version attached, if it looks okay to you this is checkin-needed
Attachment #589370 - Attachment is obsolete: true
Attachment #589921 - Flags: review?(Ms2ger)
Comment on attachment 589921 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

lgtm, thanks
Attachment #589921 - Flags: review?(Ms2ger) → feedback+

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a322365e2d4
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3a322365e2d4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Version: unspecified → Trunk

Comment 8

6 years ago
Added to DOM fuzzer :)
You need to log in before you can comment on or make changes to this bug.