718899 - Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[John Schoenick [:johns]]

Attachment: Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

Per discussion in #jsapi

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 589370 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

>@@ -3622,35 +3630,47 @@ class PreciseGCRunnable : public nsRunna
>         JSContext *cx;
>         JSContext *iter = nsnull;
>         while ((cx = JS_ContextIterator(rt, &iter)) != NULL) {
>             if (JS_IsRunning(cx)) {
>                 return NS_DispatchToMainThread(this);
>             }
>         }
> 
>-        JS_GC(mCx);
>+        if (mShrinking)
>+          JS_ShrinkingGC(mCx);
>+        else
>+          JS_GC(mCx);

Looks like the indentation should be 4 here.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Is there any reason to make the argument to PreciseGCRunnable optional?

Comment 4

[John Schoenick [:johns]]

Attachment: Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

@Ms2ger - Not particularly, its only a helper class in this file. Changed version attached, if it looks okay to you this is checkin-needed

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 589921 [details] [diff] [review]
Implement Cu.forceShrinkingGC / Cu.schedulePreciseShrinkingGC

lgtm, thanks

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a322365e2d4

Comment 7

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/mozilla-central/rev/3a322365e2d4

Comment 8

[Jesse Ruderman]

Added to DOM fuzzer :)