719006 - Investigate the future of the tabmail-buttons (calendar-tab-button and task-tab-button)

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

Bug 582801 introduced a real toolbar on the tab-bar and marked the tabmail-buttons as deprecated. We should investigate what we are doing with the two buttons in this box (calendar-tab-button and task-tab-button).

Possible solutions are:

1. Move the two buttons from #tabmail-buttons to #tabbar-toolbar and let them
   not removable as they are now in this toolbar.
2. As 1. but make the buttons removable.
3. Remove this two buttons and use the two already existing toolbar-buttons
   #lightning-button-calendar and #lightning-button-tasks instead.

Solution 1 is the easiest and for the user this would be no markable change. Solution 2 is flexible but we could irritate the user with two sets of movable buttons which are doing the same. Solution 3 can work for new users but what is with old users which have customized their toolbars with this buttons?

Do you have other solutions?

Comment 1

[Richard Marti (:Paenglab)]

I added you to CC for a first feedback. What do you mean?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think option 1 makes most sense. Its too bad the tabmail-buttons are going away. I liked the fact that the calendar icons were large and visible.

How large are the #tabbar-toolbar icons?

Comment 3

[Richard Marti (:Paenglab)]

There is no difference in size. The #tabbar-toolbar is fixed to small size because big size makes no sense in the tab-bar.

Comment 4

[Stefan Sitter [:ssitter]]

I'd remove the obsolete tabmail-buttons and add two new buttons to the new tab toolbar. Buttons should be displayed by default after installation. But the user should be allowed to remove them.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Move the buttons to tabbar-toolbar

This is solution 1, move the buttons from tabmail-buttons to tabbar-toolbar. The only difference would be the two buttons are now on the right side of the Quick Filter button instead of at the left side. I could add a insertbefore="QFB-button" but what happens when this button is removed or in a other toolbar? And the TB devs are thinking about removing this button from this bar (Bug 717264).

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 590456 [details] [diff] [review]
Move the buttons to tabbar-toolbar

Review of attachment 590456 [details] [diff] [review]:
-----------------------------------------------------------------

If you add in insertbefore="invalidbuttonId" then it will just ignore it and append to the end as usual, so go ahead and do that.

What about the icons, can we use the old icons? Also, what about new users? Are the buttons automatically in the default set, or do they need to be added on first run?

Given the above are non-issues, r=philipp

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> If you add in insertbefore="invalidbuttonId" then it will just ignore it and
> append to the end as usual, so go ahead and do that.

Okay, then I'll do it.

> What about the icons, can we use the old icons? Also, what about new users?
> Are the buttons automatically in the default set, or do they need to be
> added on first run?

It is only a move the icons are still the same and also for new users they are immediately shown.

Comment 8

[Richard Marti (:Paenglab)]

It looks Calendar doesn't have a approval-comm-aurora, so I'm asking here:

Is it okay to land this patch on aurora? The Tabs-on-top patch is also on aurora.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 590456 [details] [diff] [review]
Move the buttons to tabbar-toolbar

a=philipp for aurora

Comment 10

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/e828b319282e>
and comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/da70672b466a>

With insertbefore= it didn't worked but with defaultset= for the toolbar it worked to position the buttons. So I used this.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hmm not sure modifying the default set in an overlay is the right thing to do. If another extension adds something to the default set, then this overlay might override it. I could be wrong though.