719016 - responding to invitations as an attendee fails to set the "SENT-BY" attribute

Status: RESOLVED FIXED

Description

[Wolfgang Sourdeau]

The patch in #586276 enables to detect which calendars are accessed by its owner or a delegate. However, it fails to properly set the "SENT-BY" attribute to the relevant "ATTENDEE" element when the active user reponds on behalf of someone else.

Comment 1

[Wolfgang Sourdeau]

Attachment: Initial and probably final patch

This patch performs the missing actions. Note that it's very similar to the code in calItipUtils.jsm. The latter could be removed if the imip-bar interface did not depend on it... but this would require a controller object for calIItem objects.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Pushed to comm-central changeset 6559b1814a9b

Comment 3

[Philipp Kewisch [:Fallen] [:📆]]

Backported to releases/comm-aurora changeset 8e05a7b2b593

Comment 4

[Philipp Kewisch [:Fallen] [:📆]]

Backported to releases/comm-beta changeset f3ea9030a44b

Comment 5

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 589486 [details] [diff] [review]
Initial and probably final patch

Oh, oops. r=philipp of course.

Comment 6

[Simon Vaillancourt]

I am reopening this bug because SENT-BY must always be inside double quotes, this patch makes Lightning produce invalid iCalendar data. and the mailto scheme is also missing.

Comment 7

[Stefan Sitter [:ssitter]]

Simon, see Bug 722635.

Comment 8

[Simon Vaillancourt]

Patch for bug 722635 resolves the issue I reported in comment 6.