Closed Bug 719016 Opened 9 years ago Closed 9 years ago

responding to invitations as an attendee fails to set the "SENT-BY" attribute

Categories

(Calendar :: Dialogs, defect)

Product:
Calendar
Component:
Dialogs
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: WSourdeau, Assigned: WSourdeau)

Details

Attachments

(1 file)

Initial and probably final patch
943 bytes, patch
Fallen
: review+
Details | Diff | Splinter Review 
The patch in #586276 enables to detect which calendars are accessed by its owner or a delegate. However, it fails to properly set the "SENT-BY" attribute to the relevant "ATTENDEE" element when the active user reponds on behalf of someone else.
Assignee: nobody → WSourdeau
OS: Mac OS X → All
This patch performs the missing actions. Note that it's very similar to the code in calItipUtils.jsm. The latter could be removed if the imip-bar interface did not depend on it... but this would require a controller object for calIItem objects.
Attachment #589486 - Flags: review?
Pushed to comm-central changeset 6559b1814a9b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
Backported to releases/comm-beta changeset f3ea9030a44b
Target Milestone: 1.3 → 1.2
Comment on attachment 589486 [details] [diff] [review]
Initial and probably final patch

Oh, oops. r=philipp of course.
Attachment #589486 - Flags: review? → review+
I am reopening this bug because SENT-BY must always be inside double quotes, this patch makes Lightning produce invalid iCalendar data. and the mailto scheme is also missing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Simon, see Bug 722635.
Patch for bug 722635 resolves the issue I reported in comment 6.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.