Building releases M18 - 0.8 and nightly, configure --disable-debug causes the MIPSpro 188.8.131.52m compiler to seg fault in Code_Expansion phase (signal 4) on each of the following files layout/base/src/nsPresContext.cpp layout/html/base/src/nsObjectFrame.cpp layout/html/document/src/nsHTMLContentSink.cpp or content/html/document/src/nsHTMLContentSink.cpp Initial investigation shows NS_CheckContentLoadPolicy is common between these files, and I was able to get nsHTMLContentSink.cpp to compile by removing the lines around NS_CheckContentLoadPolicy (Mozilla then core dumped in an un- related section) http://lxr.mozilla.org/seamonkey/ident?i=NS_CheckContentLoadPolicy
Created attachment 27672 [details] [diff] [review] While not cross-platform; this diff does allow --disable-debug to compile on IRIX
Summary: MIPSpro 184.108.40.206m Seg Faults after configure --disable-debug → MIPSpro 220.127.116.11m Seg Faults after configure --disable-debug
Removing the PR_BEGIN/END macros sounds like a Bad Idea (tm). Reassigning to the layout team . cc'ing scc for advice on potential compiler funkiness and cc'ing shaver as lxr claims he last touched that macro.
Assignee: cls → karnaze
Status: UNCONFIRMED → NEW
Component: Build Config → Layout
Ever confirmed: true
QA Contact: granrose → petersen
Reassigning to waterson and moving to m0.9.1
Assignee: karnaze → waterson
Target Milestone: --- → mozilla0.9.1
cls is right: removing the PR_[BEGIN|END]_MACRO stuff is bad: it declares a local variable. Since I don't have access to this wonderful compiler, I can't really explore other alternatives. heikki: do you have any ideas?
Priority: -- → P4
Target Milestone: mozilla0.9.1 → Future
Not sure why I was Cc:d. I don't know of that compiler, and the code isn't exactly my area either. But, to me it looks like in this case it would be pretty safe to remove the PR_BEGIN|END macros because the CHECK_CONTENT_POLICY macro is only used inside NS_CheckContentLoadPolicy and NS_CheckContentProcessPolicy functions in file nsContentPolicyUtils.h, and at the end of the file CHECK_CONTENT_POLICY is undefined so you can't even use it anywhere else.
Ok, then. Let's do it. shaver? r=?
Just hand-expand that macro in the two functions, and let's get on with our lives.
i'll check it in as soon as I get a sane tree.
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Marking verified per last comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.