71912 - add email pref "if I'm added to that capacity"

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Daniel Veditz [:dveditz]]

I like the flexibility of the new bugzilla mail prefs--kudos to all--but I 
think the "CC" option missed the boat.

In part e-mail notifications are a convenience, an "event" if you will, but in 
large part they are there so we can keep an eye out for damage to the bug data 
(whether well-meaning or malicious). I don't give a hoot if Joe CC's himself or 
removes himself, but I do care if

1) someone CC's me on a bug -- it means they think I should look at it

2) someone removes my CC from a bug -- why the f*** did they do that?

3) someone adds or removes non-self CC's on bugs I'm otherwise watching -- keep 
an eye out for potential mischief.

There are too many Joes, so I and most everyone will turn off the CC 
notifications. This means that in case 1) I may not see the bug for a while, 
not until the next update. This will in turn result in some folks 
figuring this out and so adding a comment at the same time they CC me, 
defeating the purpose for folks who turn off the CC field. In the second case I 
may simply never know, and will thus miss whatever I was watching for. And in 
the third case I'll not notice that someone is munging my bugs.

I think this needs re-thinking a bit.

Comment 1

[Dawn Endico]

I think that if you check that you want to ignore changes to the
cc field you should still get notifications if someone adds or removes
you.  Points 1 and 2 would be fixed by this.

Setting target milestone to 2.12 as a nomination since I think doing
this would be relatively easy and greatly improve usability. If the
triage establishment disagrees then feel free to change.


If you're worried about point 3 then don't turn off cc notifications.

Comment 2

[Andreas Franke (gone)]

I think 2) is covered by the "if I'm removed from that capacity" checkbox.
So the main missing thing is 1). I agree that an "if I'm added to that capacity"
option would be useful in general. The new option should default to on, i.e. do
send notifications, as it is already the case with "if I'm removed from that
capacity". 

At some point, people may agree that a pref for these may not even be needed
because the defaults are useful for everyone. But then it would be impossible to
turn off _all_ bugzilla mail, so maybe an alternative for "disabling" your
account should be offered then.

I think 3) is still useful IMO, but if it is more complicated to implement then
it deserves its own bug/rfe, and it's certainly not critical for 2.12.

Comment 3

[Stephan Niemz]

This report covers more than one bug. :-(

I agree with Andreas that (3) deserves a new bug report, and that (2) is already
covered by "if I'm removed from that capacity".  So as the remaining thing is
(1), I'm updating the summary.

And I agree that this is not critical for 2.12, at least if we want to release
2.12 soon now, but I'll let others change the target milestone.  In practice,
when someone adds someone else to a Cc list, he usually adds a comment with a
question or remark for that person.  So as it's not a Cc-only change then, that
person should get the mail anyway.

Comment 4

[Andreas Franke (gone)]

Just in case there was a misunderstanding here: I was only referring to 3) as
not critical for 2.12; I didn't say anything about option 1).

Comment 5

[Jacob Steenhagen]

Taking this one.  What I'm planning on doing is changing the "If I'm removed
from that capacity" option to "If the changes" which will handle added or removed.

Comment 6

[Jacob Steenhagen]

Attachment: Patch - Change Removeme functionality (and wording on the prefs page)

Comment 7

[Jacob Steenhagen]

OK, this patch expands 2 to include 1.  I personally have no desire to do 3.

Comment 8

[Andreas Franke (gone)]

I have neither tested your patch nor reviewed it in the context of the
surrounding code, but I have some comments:
- AFAICT "filterExcludeList" computes a set difference A \ B, and this is what
you are using it for. Maybe it should be renamed to "computeSetDiff" or
"SetDiff" to make the semantics more obvious?
- Does it make sense to factor out the duplicate filtering part of that routine?
(Maybe for Bugzilla 3.0?)
- You are not checking for reporter changes. This is currently not possible, but
it may be possible in the future. Maybe this is worth a comment, maybe not.

Comment 9

[Jacob Steenhagen]

True, I'm not using filterExcludeList for the purpose it's intended, but it does
work nicely.  As for renaming the sub, I suppose that could be done... I suppose
it could even be moved to globals.pl if it's found to be useful in more than
just processmail.

Also true, I didn't include support for "If my status as reporter changes".  Of
course, making it possible to change the reporter is (AFAIK) not planned, and if
it were, it'd require far more code change than the extra two lines here :)

Comment 10

[Dave Miller [:justdave]]

r= justdave

checked in.

Comment 11

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product