719193 - Open/Delete Commands are always disabled

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Using Lighting 1.4 and 1.3, the command controller seems to disable the delete and modify commands incorrectly. Doubleclicking on events to open them still works though.

The command controller is a real pain and must die, but until it dies we need to fix this...

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Raising to critical, since its on beta now...

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Regression from bug 351870. The select event is suppressed here: <http://hg.mozilla.org/comm-central/rev/80959a308cf7#l3.28>

Markus, could you shed some light as to why this was needed?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 4

[Markus Adrario [:Taraman]]

Comment on attachment 594573 [details] [diff] [review]
Fix - v1

I played around with this suppression while I was tackling some problems with the patch and it must have slipped in the final version. As far as I can see no need for it.
With the patch applied the deselection still works.

r=markus

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset b1c2824bfe7e

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 0e082f56031d

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-beta changeset e7a7144bdb7f