719222 - Hook up the new developer program enrollment

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Wil Clouser [:clouserw]]

This is basically a placeholder because I need to file bugs but don't have mockups.  Essentially this is:

- For new developers, the first time the upload their add-on they have to agree to this blob of legalese and give us some personal info
- For existing developers, the next time they try to edit their add-ons, they need to agree to this blob of legalese and give us some personal info

We have to store the date they agreed to this in the database as a new field.  This is stored per-user (not per add-on).

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #0)
> - For existing developers, the next time they try to edit their add-ons,
> they need to agree to this blob of legalese and give us some personal info

Is this still the case? And if so, what should it look like?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> (In reply to Wil Clouser [:clouserw] from comment #0)
> > - For existing developers, the next time they try to edit their add-ons,
> > they need to agree to this blob of legalese and give us some personal info
> 
> Is this still the case? And if so, what should it look like?

Fligtar, what should this look like?

Comment 3

[Wil Clouser [:clouserw]]

whatever is easiest.  Either forward to the other URL and then return or use a lightbox.

It's going to be pretty annoying for people who just want to go in and change something quickly to have to re-read our terms of service.  We should add a note about what is happening, eg. "We've changed our Developer Agreement to accommodate some changes in the upcoming Marketplace.  Please review and agree to the text below[...]"

Not sure if we need an explanation of what to do if people don't agree.  If fligtar doesn't say we do, skip it.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Not a blocker!

Comment 5

[Wil Clouser [:clouserw]]

Applies to add-ons so not blocking our marketplace milestones

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Since we auto-generate users' display names from a slug of their Persona email addresses, we've been getting a lot of weird display names on app detail pages:

http://f.cl.ly/items/200w1G1U0t1j340P0z3O/Screen%20shot%202012-08-20%20at%204.15.48%20PM.png
http://f.cl.ly/items/3h0g1m0R1O2m0S1k0N2G/Screen%20shot%202012-08-20%20at%204.15.04%20PM.pnghttp://f.cl.ly/items/1p1G2S3Z252x421I0a15/Screen%20shot%202012-08-20%20at%204.15.25%20PM.png
http://f.cl.ly/items/2H0I460y3Z0K382s3G1X/Screen%20shot%202012-08-20%20at%204.15.37%20PM.png

It might be a good opportunity to have the developer double check their display name when they submit an app/agree to the TOS.

I was thinking something like this, an input box prefilled to the display name we auto-generated:

    Your Display Name:
    <input type="text" name="display_name" value="{{ request.amo_user.display_name }}">

And that would just save their display name.

Comment 7

[Andy McKay]

This is just for when the developer agreement gets changed? If so it looks like this requirement needs a timestamp that we set each time the TOS changes. When that occurs we can compare that against when they agreed to the TOS and ping the developer.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andy McKay [:andym] from comment #7)
> This is just for when the developer agreement gets changed? If so it looks
> like this requirement needs a timestamp that we set each time the TOS
> changes. When that occurs we can compare that against when they agreed to
> the TOS and ping the developer.

Oh is it? I thought this was for the first-time developer enrollment (the first app submitted/the first time accessing DevHub). But yeah that also sounds like something we need.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Yeah looks like both from comment 0.

Comment 10

[Andy McKay]

Doesn't the devhub have submission flow that requires them to accept the TOS before submitting?

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #10)
> Doesn't the devhub have submission flow that requires them to accept the TOS
> before submitting?

Yep

Comment 12

[Andy McKay]

@fligtar: if the TOS changes, is that a blocker for doing anything in the devhub until they agree. If they don't agree, do we do anything?

Comment 13

[Andy McKay]

Checks for agreement being out of date:

https://github.com/andymckay/zamboni/commit/81cfd2

But would like to know more from @fligtar before continuing.

Comment 14

[Wil Clouser [:clouserw]]

Maybe David can answer that question.  CCing

Comment 15

[David Bialer [:dbialer]]

IMHO, the answer is yes as the TOS currently is.  The other thing, is that the TOS not just governs submissions, but all existing apps as well.  So really, we should be disabling existing apps from being distributed.  But I will check with legal as I am not sure if this is the right thing.

The way another big name market works, they give you 30 day notice of new terms. After 30 days and if you haven't accepted, applications get blocked from being listed until new TOS are agreed to (as opposed to prevention of submission and/or updates). New developers agree to a new TOS - so, in affect, there may be more than 1 TOS in affect at the same time until 30 days are up.  The current TOS by Mozilla requires no notification to developers.

Comment 16

[Andy McKay]

If this is the case, we'll need big red letters spelling out what happens if they don't accept the ToS. The 30 day lag sounds reasonable. I'll wait till you've heard from legal on this.

Thanks for looking into it.

Comment 17

[David Bialer [:dbialer]]

I will change my answer here - re-reading the TOS.  We do not require any further acceptance of a new TOS just posting the fact that the TOS has changed and what those changes are.  This may not be the best practice, but this is what it is.  I do not believe that the developer has to agree to an updated TOS.  see below. 

I will follow up with legal to see if this is, in fact, the practice that we should follow.

"As we innovate and introduce new features for the Firefox Marketplace, these Terms may need to change.  We reserve the right to change these Terms in our sole discretion and if we do make changes, we will post a notice on the Firefox Marketplace describing the changes that were made, so make sure to check back periodically.  If you have any questions about these Terms or the Firefox Marketplace, please email us."

Comment 18

[Wil Clouser [:clouserw]]

What was the response from legal?

Comment 19

[Andy McKay]

Based on comment #17, when the ToS is changed, we show a banner message for that user pointing to the new ToS until they go and click agree again. But we don't restrict anything, just annoy people :)

https://github.com/mozilla/zamboni/commit/850c70