719302 - [Azure] Expose Azure status in about:support

Status: RESOLVED DUPLICATE of bug 776802

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Expose Azure status in about:support

Comment 1

[Joe Drew (not getting mail)]

Comment on attachment 589737 [details] [diff] [review]
Expose Azure status in about:support

Review of attachment 589737 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +318,5 @@
> +    // display registered graphics properties
> +    var info = gfxInfo.getInfo();
> +    for (var property in info) {
> +      pushLiteralInfoRow(trGraphics, property, info[property]);
> +    }

This should probably come at the end, since it's just going to be a grab-bag?

@@ +328,5 @@
> +    try {
> +      azureContent = Services.prefs.getBoolPref("gfx.content.azure.enabled");
> +    } catch (e) {}
> +    
> +    if (info.AzureBackend) {

I think you need to wrap this in try/catch, just in case info.AzureBackend isn't defined.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 589737 [details] [diff] [review]
Expose Azure status in about:support

Review of attachment 589737 [details] [diff] [review]:
-----------------------------------------------------------------

Joe has already started reviewing this, and is better at it than I am. Handing over!

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 589737 [details] [diff] [review]
Expose Azure status in about:support

Review of attachment 589737 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/GfxInfoBase.cpp
@@ +55,5 @@
>  #include "nsIDOMNode.h"
>  #include "nsIDOMNodeList.h"
>  #include "nsTArray.h"
>  #include "mozilla/Preferences.h"
> +#include "gfxPlatform.h"

Change seems unrelated?