Last Comment Bug 719304 - don't use nsICharsetAlias on mailnews
: don't use nsICharsetAlias on mailnews
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks: 590390
  Show dependency treegraph
 
Reported: 2012-01-18 18:04 PST by Makoto Kato [:m_kato]
Modified: 2012-02-21 01:59 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix (6.65 KB, patch)
2012-02-04 22:22 PST, Makoto Kato [:m_kato]
mozilla: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-01-18 18:04:18 PST
This usage on mailnews can replace with nsICharsetConverterManager::GetCharsetAlias.
Comment 1 Makoto Kato [:m_kato] 2012-02-04 22:22:47 PST
Created attachment 594512 [details] [diff] [review]
fix
Comment 2 Makoto Kato [:m_kato] 2012-02-06 23:06:20 PST
Comment on attachment 594512 [details] [diff] [review]
fix

need for decom of nsICharsetAlias
Comment 3 David :Bienvenu 2012-02-14 16:50:55 PST
Comment on attachment 594512 [details] [diff] [review]
fix

Thx for the patch; it looks good;
Can you wrap the longer lines at 80 columns (there are several), and remove the space after nsCOMPtr here (occurs twice):

+  nsCOMPtr <nsICharsetConverterManager> ccm = do_GetService(NS_CHARSETCONVERTERMANAGER_CONTRACTID, &rv);
Comment 4 Makoto Kato [:m_kato] 2012-02-21 01:59:29 PST
http://hg.mozilla.org/comm-central/rev/843f0c541a64

Note You need to log in before you can comment on or make changes to this bug.