don't use nsICharsetAlias on mailnews

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Backend
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
Thunderbird 13.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This usage on mailnews can replace with nsICharsetConverterManager::GetCharsetAlias.
(Assignee)

Comment 1

6 years ago
Created attachment 594512 [details] [diff] [review]
fix
(Assignee)

Comment 2

6 years ago
Comment on attachment 594512 [details] [diff] [review]
fix

need for decom of nsICharsetAlias
Attachment #594512 - Flags: review?(dbienvenu)

Comment 3

6 years ago
Comment on attachment 594512 [details] [diff] [review]
fix

Thx for the patch; it looks good;
Can you wrap the longer lines at 80 columns (there are several), and remove the space after nsCOMPtr here (occurs twice):

+  nsCOMPtr <nsICharsetConverterManager> ccm = do_GetService(NS_CHARSETCONVERTERMANAGER_CONTRACTID, &rv);
Attachment #594512 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/comm-central/rev/843f0c541a64
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.