Closed Bug 719309 Opened 9 years ago Closed 9 years ago

Disable touch events widget code

Categories

(Firefox for Android :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 - fixed

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Touch events are almost ready, but the widget code needs some... tweaking to deal correctly with asynchronous scrolling. To make things a bit easier to work on, we'd like to land them preffed off for now and file individual bugs for follow up work.
Attachment #589749 - Attachment is patch: true
Attachment #589749 - Flags: review?(mark.finkle)
Comment on attachment 589749 [details] [diff] [review]
Patch

"sendTouchEvents" -> "touchEventsEnabled"

* I assume this does not mess up GeckoPreferences gecko listener for Preference:Data
* We should probably remove this code once touch events are working well enough. I don't think we want to keep this capability.
Attachment #589749 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfa8aedbff44

Just realized I forgot to change this name. I'll push a follow up...
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/bfa8aedbff44
https://hg.mozilla.org/mozilla-central/rev/ba99528f5f11
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 12
Wes, please request aurora approval
Comment on attachment 589749 [details] [diff] [review]
Patch

User impact if declined: Needed to keep multitouch moving forward
Testing completed (on m-c, etc.): on mc since 1/24
Risk to taking this patch (and alternatives if risky): Low risk. Mobile only. Only disables new code.
Attachment #589749 - Flags: approval-mozilla-aurora?
Attachment #589749 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 603008
You need to log in before you can comment on or make changes to this bug.