Disable touch events widget code

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(firefox11- fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 589749 [details] [diff] [review]
Patch

Touch events are almost ready, but the widget code needs some... tweaking to deal correctly with asynchronous scrolling. To make things a bit easier to work on, we'd like to land them preffed off for now and file individual bugs for follow up work.
(Assignee)

Updated

5 years ago
Attachment #589749 - Attachment is patch: true
Attachment #589749 - Flags: review?(mark.finkle)
Comment on attachment 589749 [details] [diff] [review]
Patch

"sendTouchEvents" -> "touchEventsEnabled"

* I assume this does not mess up GeckoPreferences gecko listener for Preference:Data
* We should probably remove this code once touch events are working well enough. I don't think we want to keep this capability.
Attachment #589749 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfa8aedbff44

Just realized I forgot to change this name. I'll push a follow up...
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba99528f5f11 - variable rename
https://hg.mozilla.org/mozilla-central/rev/bfa8aedbff44
https://hg.mozilla.org/mozilla-central/rev/ba99528f5f11
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 12
Wes, please request aurora approval
(Assignee)

Comment 6

5 years ago
Comment on attachment 589749 [details] [diff] [review]
Patch

User impact if declined: Needed to keep multitouch moving forward
Testing completed (on m-c, etc.): on mc since 1/24
Risk to taking this patch (and alternatives if risky): Low risk. Mobile only. Only disables new code.
Attachment #589749 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #589749 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Blocks: 603008
(Assignee)

Updated

5 years ago
tracking-firefox11: --- → ?
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/f5e015526fde
status-firefox10: --- → fixed
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/fffeb5ffd845
status-firefox10: fixed → ---
status-firefox11: --- → fixed

Updated

5 years ago
tracking-firefox11: ? → -
You need to log in before you can comment on or make changes to this bug.