Closed Bug 719357 Opened 13 years ago Closed 13 years ago

Add a lock around the cleanup script for tinderbox-builds dirs

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

Details

They run every how, and if the I/O conditions are slow then we can end up with more than one running simultaneously.
They run every hour, even.
Locks added, and also cleaned up the cronspam we were getting about empty dirs, eg mv: cannot stat `mozilla-central-linux64-debug/1327116056/*': No such file or directory mv: cannot stat `mozilla-central-linux64-pgo/1327111201/*': No such file or directory
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to Nick Thomas [:nthomas] from comment #2) > Locks added, and also cleaned up the cronspam we were getting about empty > dirs, eg > mv: cannot stat `mozilla-central-linux64-debug/1327116056/*': No such file > or directory > mv: cannot stat `mozilla-central-linux64-pgo/1327111201/*': No such file or > directory Any chance you can share what you changed, specifically. I'd like to mirror it for the seamonkey cleanup scripts.
Wrapped it with a lockfile call and cleanup, originally from catlee. @hourly lockfile -r 0 /tmp/firefox_tinderbox-builds.lock 2> /dev/null && (nice -n 19 $HOME/bin/cleanup_tinderbox-builds.sh /pub/mozilla.org/firefox/tinderbox-builds; rm -rf /tmp/firefox_tinderbox-builds.lock) I haven't used this on the more common find commands because they normally handle deletion rather than moves.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.