719402 - Implement plural forms for real in l10n module.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

Currently, l10n module only implements engligh plural forms:
https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/l10n.js#L37-42


We need to implement specific set of forms for each language, by following rules described here:
http://unicode.org/repos/cldr-tmp/trunk/diff/supplemental/language_plural_rules.html

We may use code provided by PluralForms.jsm:
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/PluralForm.jsm#67

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 332

-> more information in the pull request.

Comment 2

[Alexandre Poirot [:ochameau]]

Here is the documentation for current XUL way of doing localization with plural forms:
https://developer.mozilla.org/En/Localization_and_Plurals#Plural_rule_.2312_%286_forms%29

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 591814 [details]
Pull request 332

As you already reviewed the very first l10n patch, I'd think that you may review this one too? Feel free to redirect the review to Irakli if you do not feel reviewing JS code.

Comment 4

[Brian Warner [:warner :bwarner]]

I've added comments to the pull request.. looks mostly good, one potential real bug, a handful of style recommendations.

Comment 5

[Brian Warner [:warner :bwarner]]

Comment on attachment 591814 [details]
Pull request 332

Looks good: r+ with or without the remaining minor suggestions on the pull-request

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e0aaf738d89ac77341ca39594a7ff4b028292093
Merge pull request #332 from ochameau/implement-plural-forms

Bug 719402 - Implement plural forms r=@warner