Closed Bug 71941 Opened 23 years ago Closed 23 years ago

PR_CALLBACK missing in layout/html/base/nsPresShell.cpp

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
Other
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.8.1

People

(Reporter: achimha, Assigned: rods)

Details

Attachments

(2 files)

proposed patch
1.85 KB, patch
Details | Diff | Splinter Review
Use PR_STATIC_CALLBACK rather than PR_CALLBACK
1.86 KB, patch
Details | Diff | Splinter Review 
Hashtable callback functions without the proper callback flag. This is
a build blocker for OS/2 and must go in before branch. Patch follows.
Attached patch proposed patch — — Splinter Review 

    
    

    
  
Shouldn't that be PR_STATIC_CALLBACK(PRIntn) then?

    
    

    
  
yes, it should be PR_STATIC_CALLBACK if it is needed.

    
    

    
  
Reassigning to Rods.
Assignee: karnaze → rods
Target Milestone: --- → mozilla0.9

    
    

    
  
We're not sure why this isn't breaking the tinderbox. It's definitely breaking 
our builds.

The change does not impact other platforms because PR_STATIC_CALLBACK is only 
set for OS/2.

    
    

    
  
r=jag

    
    

    
  
changing target milestone to 0.8.1
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9 → mozilla0.8.1

    
    

    
  
I got approval from pchen on IRC to get this in.

Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Marking verified per last comments.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: