IonMonkey: enable SETPROP PIC/stubs for ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bhackett, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 713526 aborts on encountering SETPROP in ARM due to some not yet implemented assembler bits.
Created attachment 598484 [details] [diff] [review]
/home/mrosenberg/patches/addSetProp-r0.patch

Most of this patch was fixing the types of the setprop functions, since callvm does not work with Values at all on arm, and in general, should not pass values by value.
Attachment #598484 - Flags: review?(bhackett1024)
(Reporter)

Comment 2

5 years ago
Comment on attachment 598484 [details] [diff] [review]
/home/mrosenberg/patches/addSetProp-r0.patch

Review of attachment 598484 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/shared/CodeGenerator-shared.cpp
@@ +380,5 @@
>          // it returns.
>          argumentPadding = (fun.explicitStackSlots() * sizeof(void *)) % StackAlignment;
>          masm.reserveStack(argumentPadding);
>      }
> +    //masm.breakpoint();

rm
Attachment #598484 - Flags: review?(bhackett1024) → review+
landed: http://hg.mozilla.org/projects/ionmonkey/rev/707fcb980e96
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.