Closed Bug 719433 Opened 11 years ago Closed 11 years ago

IonMonkey: enable SETPROP PIC/stubs for ARM

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bhackett1024, Unassigned)

References

Details

Attachments

(1 file)

/home/mrosenberg/patches/addSetProp-r0.patch
11.13 KB, patch
bhackett1024
: review+
Details | Diff | Splinter Review 
Bug 713526 aborts on encountering SETPROP in ARM due to some not yet implemented assembler bits.
Most of this patch was fixing the types of the setprop functions, since callvm does not work with Values at all on arm, and in general, should not pass values by value.
Attachment #598484 - Flags: review?(bhackett1024)
Comment on attachment 598484 [details] [diff] [review]
/home/mrosenberg/patches/addSetProp-r0.patch

Review of attachment 598484 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/shared/CodeGenerator-shared.cpp
@@ +380,5 @@
>          // it returns.
>          argumentPadding = (fun.explicitStackSlots() * sizeof(void *)) % StackAlignment;
>          masm.reserveStack(argumentPadding);
>      }
> +    //masm.breakpoint();

rm
Attachment #598484 - Flags: review?(bhackett1024) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.