719617 - SDK 1.4 files cause warnings in the validator

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: xpi built with SDK version 1.4 final.

If I validate an addon created with SDK 1.4, validation produces a number of warnings from code found in the SDK's own code. The validator data is slightly out of date, it does not include SDK version 1.4.

Note: SDK tag 1.4rc4 should be identical to SDK tag 1.4, however I do not think the current jetpack_data.txt file includes the 1.4 tag. If the validator code depends on the tag name in some way, this could cause problems.

Comment 1

[Wil Clouser [:clouserw]]

https://raw.github.com/mozilla/amo-validator/master/validator/testcases/jetpack_data.txt includes 1.4 hashes committed on the 10th (and live in prod) so I'm not sure why the warnings are shown.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Wil Clouser [:clouserw] from comment #1)
> https://raw.github.com/mozilla/amo-validator/master/validator/testcases/
> jetpack_data.txt includes 1.4 hashes committed on the 10th (and live in
> prod) so I'm not sure why the warnings are shown.

Right, the 1.4 tag is in jetpack_data.txt. Matt: when you get a sec can you triy validating the supplied xpi to see what the issue might be?

Comment 3

[Matt Basta [:basta]]

Jeff: Does the SDK modify the SDK library files in any way now? I.e.: does it change whitespace, inject IDs, or do anything else that would cause the hashes of the contents contents of those JS files not to match the hashes in the repo?

Comment 4

[Matt Basta [:basta]]

On closer inspection, the format of harness-options.json was greatly changed in 1.4. I'll need some time to make the changes to the validator in order to remain backward compatible with the SDK 1.3 and below, particularly since there's no real documentation to harness-options.json.

Comment 5

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/amo-validator/pull/113

In the future, it would be extremely helpful if changes to harness-options.json were properly documented or there was a descriptive change log (I was unable to find one).

Comment 6

[Andreas Wagner [:TheOne] [use NI]]

Matt, thank you for the fix!

Comment 7

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/d968deabbd7c0b05754c74d2a174691b6f53b33c

Comment 8

[Kumar McMillan [:kumar]]

Pushed to Zamboni https://github.com/mozilla/zamboni/commit/58a004fdfd5008cc923f0f16b7afa206da862426

Comment 9

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Matt Basta from comment #4)
> On closer inspection, the format of harness-options.json was greatly changed
> in 1.4. I'll need some time to make the changes to the validator in order to
> remain backward compatible with the SDK 1.3 and below, particularly since
> there's no real documentation to harness-options.json.

Matt: that's an excellent point - I am sure that we did not realize we had this dependency. In the future we need to add testing with the validator to the testing regime as this would have revealed this issue to us prior to release!