Get rid of window mediator's getMostRecentBrowserWindow across Tilt codebase

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tilt])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Because it's redundant.
(Assignee)

Updated

6 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
(Assignee)

Comment 1

6 years ago
Created attachment 590164 [details] [diff] [review]
v1
Attachment #590164 - Flags: review?(rcampbell)
which bug does this depend on?
(Assignee)

Updated

6 years ago
Depends on: 719049
(Assignee)

Updated

6 years ago
Blocks: 719732
Comment on attachment 590164 [details] [diff] [review]
v1

+ * @param {Window} aChromeWindow
+ *                 the top-level browser window
+ *
  * @param {Number} the zoom ammount
  */
-TiltUtils.setDocumentZoom = function TU_getDocumentZoom(aZoom) {
-  TiltUtils.getBrowserWindow()
-           .gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom;
+TiltUtils.setDocumentZoom = function TU_setDocumentZoom(aChromeWindow, aZoom) {
+  aChromeWindow.gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom;
 };


I thought we were going to do this:
  /**
   * Store page zoom factor.
   */
  computeZoomFactor: function Highlighter_computeZoomFactor() {
    this.zoom =
      this.win.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
      .getInterface(Components.interfaces.nsIDOMWindowUtils)
      .screenPixelsPerCSSPixel;
  },

for that.

I bet that's in another patch, isn't it.
Attachment #590164 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 4

6 years ago
(In reply to Rob Campbell [:rc] (robcee) from comment #3)
> I bet that's in another patch, isn't it.

Yup, bug 719877.
https://hg.mozilla.org/integration/fx-team/rev/e4216a369836
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e4216a369836
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.