Closed
Bug 719731
Opened 12 years ago
Closed 12 years ago
Get rid of window mediator's getMostRecentBrowserWindow across Tilt codebase
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [tilt])
Attachments
(1 file)
19.44 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Because it's redundant.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #590164 -
Flags: review?(rcampbell)
Comment 2•12 years ago
|
||
which bug does this depend on?
Comment 3•12 years ago
|
||
Comment on attachment 590164 [details] [diff] [review] v1 + * @param {Window} aChromeWindow + * the top-level browser window + * * @param {Number} the zoom ammount */ -TiltUtils.setDocumentZoom = function TU_getDocumentZoom(aZoom) { - TiltUtils.getBrowserWindow() - .gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom; +TiltUtils.setDocumentZoom = function TU_setDocumentZoom(aChromeWindow, aZoom) { + aChromeWindow.gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom; }; I thought we were going to do this: /** * Store page zoom factor. */ computeZoomFactor: function Highlighter_computeZoomFactor() { this.zoom = this.win.QueryInterface(Components.interfaces.nsIInterfaceRequestor) .getInterface(Components.interfaces.nsIDOMWindowUtils) .screenPixelsPerCSSPixel; }, for that. I bet that's in another patch, isn't it.
Attachment #590164 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Rob Campbell [:rc] (robcee) from comment #3) > I bet that's in another patch, isn't it. Yup, bug 719877.
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e4216a369836
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e4216a369836
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•