Closed
Bug 719873
Opened 14 years ago
Closed 14 years ago
All use of render_to_string that don't need `request` shouldn't ask for it
Categories
(Webtools Graveyard :: Elmo, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(1 file)
|
3.81 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
Functions inside views.py files that take `request` as a first positional argument might appear like Django view functions but they're not and should therefore not use RequestContext if they don't actually need it. ``import this``
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #590361 -
Flags: review?(l10n)
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 590361 [details] [diff] [review]
render_to_string functions refactored
Review of attachment 590361 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, with the removal of the l10nstats snippet call, or that as a follow up bug.
::: apps/homepage/views.py
@@ +111,4 @@
> return redirect('homepage.views.teams')
>
> from l10nstats.views import teamsnippet as stats_snippet
> + l10nstats_div = mark_safe(stats_snippet(loc))
I think we should really just drop calling in to this at all. The new team page doesn't use this div.
Fine as a follow-up though.
Attachment #590361 -
Flags: review?(l10n) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Assignee: nobody → peterbe
Target Milestone: --- → 2.1
|
||
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•