If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

fix loading of host-specific config

RESOLVED FIXED

Status

Cloud Services
Server: Sync
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rfkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 590271 [details] [diff] [review]
patch fixing host-specific config loading

The host-specific loading of storage config introduced in Bug 681768 is broken.  It treats the entire setting name as a hostname rather than extracting just the host portion.  So given a config like this:

    [host:some-test-host]
    storage.sqluri = sqlite:////tmp/some-test-host.db

It will create a host-specific config for "some-test-host.storage.sqluri" rather than "some-test-host".

Attached patch fixes it to strip the name of the setting.
(Reporter)

Updated

6 years ago
Attachment #590271 - Flags: review?(rmiller)
Comment on attachment 590271 [details] [diff] [review]
patch fixing host-specific config loading

Review of attachment 590271 [details] [diff] [review]:
-----------------------------------------------------------------

whoops! thx.
Attachment #590271 - Flags: review?(rmiller) → review+
(Reporter)

Comment 2

6 years ago
Thanks, committed in http://hg.mozilla.org/services/server-storage/rev/960aefce3f00
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.