Closed
Bug 719973
Opened 13 years ago
Closed 13 years ago
Failure in testAddons_changeTheme | Modal dialog has been found and processed
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Tracking
(firefox12 verified, firefox13 verified, firefox14 verified, firefox15 verified, firefox-esr10 unaffected, status1.9.2 unaffected)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox12 | --- | verified |
firefox13 | --- | verified |
firefox14 | --- | verified |
firefox15 | --- | verified |
firefox-esr10 | --- | unaffected |
status1.9.2 | --- | unaffected |
People
(Reporter: u279076, Assigned: remus.pop)
References
()
Details
(Whiteboard: [mozmill-test-failure])
Attachments
(2 files)
5.77 KB,
patch
|
AlexLakatos
:
review+
u279076
:
review+
|
Details | Diff | Splinter Review |
4.60 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
The following failure is happening on Aurora and Nightly on Windows only.
TimeoutError("Modal dialog has been found and processed")
@resource://mozmill/modules/utils.js:429
waitFor([object Proxy],"Modal dialog has been found and processed",
25000,100,[object Proxy])@resource://mozmill/modules/utils.js:467
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → remus.pop
Status: NEW → ASSIGNED
Updated•13 years ago
|
Attachment #590735 -
Flags: review?(anthony.s.hughes)
Attachment #590735 -
Flags: review?(alex.lakatos)
Attachment #590735 -
Flags: review+
Comment on attachment 590735 [details] [diff] [review]
skip test (aurora, default) [checked-in]
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/ae3054f32f67 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/43c52a230125 (mozilla-aurora)
Please verify that this test is not failing on Beta and Release either by running tests locally. If it is, this patch will need porting.
Attachment #590735 -
Attachment description: skip test (aurora, default) → skip test (aurora, default) [checked-in]
Attachment #590735 -
Flags: review?(anthony.s.hughes) → review+
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
Assignee | ||
Comment 3•13 years ago
|
||
No problem running the test 20 times locally.
Here are the reports (functional + restart) from the testrun for:
Mac:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00211d
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00334a
Windows:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a008a74
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a0097cb
Linux:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00ab26
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00bc18
I'll add the patch that enables the test and also modifies the pref for the Discovery Pane.
Assignee | ||
Comment 4•13 years ago
|
||
Please ignore the above comment. The testruns for Win and Linux have not run with refreshed repositories. Rerunning.
Assignee | ||
Comment 5•13 years ago
|
||
Again, the correct reports (order is functional then restart tests) with testAddons_changeTheme enabled:
Mac:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00211d
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a00334a
Windows:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a0101f8
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a01314b
Linux:
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a010362
http://mozmill-crowd.blargon7.com/#/functional/report/f87375a634b1a5ba746e5f763a013be5
Assignee | ||
Comment 6•13 years ago
|
||
This enables the test and sets the Discovery Pane url to a local page.
Not yet run on Aurora.
Attachment #623659 -
Flags: review?(hskupin)
Comment 7•13 years ago
|
||
Comment on attachment 623659 [details] [diff] [review]
enable test v1 (default)
Hope you don't mind me taking this review, Henrik.
Looks good to me. Please land on default branch, and wait for tomorrow's results before merging to the remaining branches.
Attachment #623659 -
Flags: review?(hskupin) → review+
Comment 8•13 years ago
|
||
Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c7d8ae93ad34
On which other branches it has to land?
(In reply to Henrik Skupin (:whimboo) from comment #8)
> Landed on default as:
> http://hg.mozilla.org/qa/mozmill-tests/rev/c7d8ae93ad34
>
> On which other branches it has to land?
I would assume all branches. This was disabled on Aurora and Nightly back in January. I think what was on Aurora in January is now on Release.
Comment 10•13 years ago
|
||
Right, it's down to Firefox 12. ESR10 is not affected. If everything is fine we will land the patch on the other branches tomorrow. Remus, please make sure that those apply cleanly.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status1.9.2:
--- → unaffected
status-firefox-esr10:
--- → unaffected
status-firefox12:
--- → affected
status-firefox13:
--- → affected
status-firefox14:
--- → affected
status-firefox15:
--- → fixed
Resolution: --- → FIXED
Comment 11•13 years ago
|
||
Wohoo this test works pretty fine and doesn't fail anymore.
Re-enabled test on all the other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/41bf8cfb04a7 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/799bd97efe8c (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/ddae69fe862c (release)
Remus, please re-enable the appropriate Litmus groups for this mozmill test across the different branches. Please list those tests here. Thanks.
Assignee | ||
Comment 12•13 years ago
|
||
Release:
https://litmus.mozilla.org/show_test.cgi?id=50756
It was not disabled.
Beta:
https://litmus.mozilla.org/show_test.cgi?id=55626
It was not disabled.
Aurora:
https://litmus.mozilla.org/show_test.cgi?id=15633
It was not disabled.
Assignee | ||
Updated•13 years ago
|
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
Comment 13•13 years ago
|
||
Strange. We should have disabled those. Anyway, would you mind updating the link to the tests in each of those tests so that they point to the right branch?
Assignee | ||
Comment 14•13 years ago
|
||
The above mentioned testcases have been updated and point now to the correct branch in the repository,
Reporter | ||
Comment 15•13 years ago
|
||
Marking this verified as I'm not seeing failures on affected branches.
Note, I am seeing instances of this failure on esr10 (currently marked unaffected).
http://mozmill-ci.blargon7.com/#/functional/failure?branch=All&platform=All&from=2012-01-13&to=2012-05-29&test=%2FrestartTests%2FtestAddons_changeTheme%2Ftest1.js&func=test1.js%3A%3AtestInstallTheme
Once on May 8th and again on April 11th.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 16•13 years ago
|
||
I don't see any modal-dialog related issues here.
Reporter | ||
Comment 17•13 years ago
|
||
(In reply to Remus Pop (:RemusPop) from comment #16)
> I don't see any modal-dialog related issues here.
Could these be new, extremely intermittent issues?
Assignee | ||
Comment 18•13 years ago
|
||
There was a widely spread problem with that issues but AFAIK it should be fixed. Please see bug 751832. Failures were due to the discovery pane not loading in the given timeout. Now we circumvent this by loading a local page in the discovery pane for tests that access Addons Manager but don't need the discovery pane.
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•