Failure in testAddons_changeTheme | Modal dialog has been found and processed

VERIFIED FIXED

Status

VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: ashughes, Assigned: remus.pop)

Tracking

unspecified
All
Windows 7

Firefox Tracking Flags

(firefox12 verified, firefox13 verified, firefox14 verified, firefox15 verified, firefox-esr10 unaffected, status1.9.2 unaffected)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
The following failure is happening on Aurora and Nightly on Windows only.

TimeoutError("Modal dialog has been found and processed")
@resource://mozmill/modules/utils.js:429 
waitFor([object Proxy],"Modal dialog has been found and processed",
25000,100,[object Proxy])@resource://mozmill/modules/utils.js:467
(Assignee)

Updated

7 years ago
Assignee: nobody → remus.pop
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Created attachment 590735 [details] [diff] [review]
skip test (aurora, default) [checked-in]

Skips the test.
Attachment #590735 - Flags: review?(alex.lakatos)
Attachment #590735 - Flags: review?(anthony.s.hughes)
Attachment #590735 - Flags: review?(alex.lakatos)
Attachment #590735 - Flags: review+
(Reporter)

Comment 2

7 years ago
Comment on attachment 590735 [details] [diff] [review]
skip test (aurora, default) [checked-in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/ae3054f32f67 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/43c52a230125 (mozilla-aurora)

Please verify that this test is not failing on Beta and Release either by running tests locally. If it is, this patch will need porting.
Attachment #590735 - Attachment description: skip test (aurora, default) → skip test (aurora, default) [checked-in]
Attachment #590735 - Flags: review?(anthony.s.hughes) → review+
(Reporter)

Updated

7 years ago
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
(Assignee)

Comment 4

7 years ago
Please ignore the above comment. The testruns for Win and Linux have not run with refreshed repositories. Rerunning.
(Assignee)

Comment 6

7 years ago
Created attachment 623659 [details] [diff] [review]
enable test v1 (default)

This enables the test and sets the Discovery Pane url to a local page.
Not yet run on Aurora.
Attachment #623659 - Flags: review?(hskupin)
Comment on attachment 623659 [details] [diff] [review]
enable test v1 (default)

Hope you don't mind me taking this review, Henrik.

Looks good to me. Please land on default branch, and wait for tomorrow's results before merging to the remaining branches.
Attachment #623659 - Flags: review?(hskupin) → review+
Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/c7d8ae93ad34

On which other branches it has to land?
(Reporter)

Comment 9

7 years ago
(In reply to Henrik Skupin (:whimboo) from comment #8)
> Landed on default as:
> http://hg.mozilla.org/qa/mozmill-tests/rev/c7d8ae93ad34
> 
> On which other branches it has to land?

I would assume all branches. This was disabled on Aurora and Nightly back in January. I think what was on Aurora in January is now on Release.
Right, it's down to Firefox 12. ESR10 is not affected. If everything is fine we will land the patch on the other branches tomorrow. Remus, please make sure that those apply cleanly.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status1.9.2: --- → unaffected
status-firefox-esr10: --- → unaffected
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → fixed
Resolution: --- → FIXED
Wohoo this test works pretty fine and doesn't fail anymore.

Re-enabled test on all the other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/41bf8cfb04a7 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/799bd97efe8c (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/ddae69fe862c (release)

Remus, please re-enable the appropriate Litmus groups for this mozmill test across the different branches. Please list those tests here. Thanks.
status-firefox12: affected → fixed
status-firefox13: affected → fixed
status-firefox14: affected → fixed
(Assignee)

Updated

7 years ago
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
Strange. We should have disabled those. Anyway, would you mind updating the link to the tests in each of those tests so that they point to the right branch?
(Assignee)

Comment 14

7 years ago
The above mentioned testcases have been updated and point now to the correct branch in the repository,
(Reporter)

Comment 15

7 years ago
Marking this verified as I'm not seeing failures on affected branches.

Note, I am seeing instances of this failure on esr10 (currently marked unaffected).
http://mozmill-ci.blargon7.com/#/functional/failure?branch=All&platform=All&from=2012-01-13&to=2012-05-29&test=%2FrestartTests%2FtestAddons_changeTheme%2Ftest1.js&func=test1.js%3A%3AtestInstallTheme

Once on May 8th and again on April 11th.
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
status-firefox13: fixed → verified
status-firefox14: fixed → verified
status-firefox15: fixed → verified
(Assignee)

Comment 16

7 years ago
I don't see any modal-dialog related issues here.
(Reporter)

Comment 17

7 years ago
(In reply to Remus Pop (:RemusPop) from comment #16)
> I don't see any modal-dialog related issues here.

Could these be new, extremely intermittent issues?
(Assignee)

Comment 18

7 years ago
There was a widely spread problem with that issues but AFAIK it should be fixed. Please see bug 751832. Failures were due to the discovery pane not loading in the given timeout. Now we circumvent this by loading a local page in the discovery pane for tests that access Addons Manager but don't need the discovery pane.
You need to log in before you can comment on or make changes to this bug.