Closed
Bug 720087
Opened 12 years ago
Closed 11 years ago
Use EventUtils sendChar() and sendKey(), instead of calling synthesizeKey() directly
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sgautherie, Unassigned)
References
(Depends on 3 open bugs, )
Details
(Whiteboard: [good first bug][mentor=sgautherie][lang=js] [meta])
sendChar() and sendKey() are higher level functions. There might be cases where synthesizeKey() is actually needed, but I don't expect them to be many. "Too many hits, displaying the first 1000" Probably worth doing this in chunks (and maybe dependent bugs), and using some kind of macro to replace them.
Reporter | ||
Updated•12 years ago
|
Comment 2•12 years ago
|
||
Hi, I plan on working on this bug. I am thinking it could be broken up by mobile, dom, services, etc ...
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Karun Dambiec from comment #2) > Hi, I plan on working on this bug. You're welcome! > I am thinking it could be broken up by mobile, dom, services, etc ... Yes, you can file blocking bugs for areas/chunks you do ;-)
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #3) > (In reply to Karun Dambiec from comment #2) > > > Hi, I plan on working on this bug. > > You're welcome! > > > I am thinking it could be broken up by mobile, dom, services, etc ... > > Yes, you can file blocking bugs for areas/chunks you do ;-) Yes, this seems like a good way, that way someone working on a particular component can review the changes. I have just completed the first patch for the password manager component.
Comment 5•12 years ago
|
||
In Bug 711906, it is saying that sendKey should be removed. Is this correct? If it is then there is no need to use sendKey instead of synthesizeKey.
Reporter | ||
Comment 6•12 years ago
|
||
(In reply to Karun Dambiec from comment #5) > In Bug 711906, it is saying that sendKey should be removed. Is this correct? > If it is then there is no need to use sendKey instead of synthesizeKey. Let's discuss that there.
Updated•12 years ago
|
Assignee: karun.84 → nobody
Reporter | ||
Updated•12 years ago
|
Status: ASSIGNED → NEW
Whiteboard: [good first bug][mentor=sgautherie][lang=js] → [good first bug][mentor=sgautherie][lang=js] [meta]
Comment 7•12 years ago
|
||
+ test: function() { sendChar("H");; }, This line has two semicolons. Remove one of them. In all the cases where sendChar is called, you should call it with the lowercase letter for the key. For example use sendChar("h") which sends the 'h' key instead of sendChar("H") which sends shift+h and could have otherwise lead to subtly differently behaviour.
Comment 8•12 years ago
|
||
Whoops, that comments was meant for bug 721512
Comment 10•11 years ago
|
||
Neil, What is the current state with this issue with send_keys vs synthesize keys etc? I think we need a new description here and a clear statement of what is required and what is needed in order for this to be a good, clear, actionable mentored bug.
Flags: needinfo?(enndeakin)
Comment 11•11 years ago
|
||
Bug 711906 is kind of wanting the opposite of this, so I think first needs to be decided if this bug or that bug gets WONTFIX-ed.
Comment 12•11 years ago
|
||
There's nothing to do in this bug. Tests should use synthesizeKey or sendChar, and there isn't any reason to change existing tests. Removing sendKey is fine too.
Flags: needinfo?(enndeakin)
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•