Closed Bug 720181 Opened 12 years ago Closed 12 years ago

Font inflation inflates text in text fields without inflating the field

Categories

(Firefox for Android Graveyard :: General, defect, P2)

defect

Tracking

(fennec11+)

RESOLVED WORKSFORME
Tracking Status
fennec 11+ ---

People

(Reporter: jwir3, Unassigned)

Details

(Whiteboard: [readability], [font-inflation: form controls])

Attachments

(1 file)

When in text fields, such as the about:config search box, if font inflation is enabled, the text within the box is inflated, but the actual box is not.

Steps to reproduce:
1) Open about:config in current mozilla trunk (doesn't need to be mobile version).
2) Type 'inflation' in the search dialog at the top.
3) Set font.size.inflation.minEmPerLine to 15.
4) Notice that the text 'inflation' in the search dialog at the top is now large, but is cut off at the top and bottom because the actual text dialog box is not inflated.
In terms of solutions, I think that we probably have two options here:

1) Inflate the text input box to the size of the text.
2) Disable text inflation for this type of input control.

I think that 2) is not quite what we want, though. (Just thinking out loud here). The reason being, that when I tested this functionality on my HTC evo 4G, the text in the search box might not be readable. Obviously, when a user is inputting the text, they'll have an android input box open, with a small keyboard, so it's probably a moot point for when the text is being entered. The difference might be when a user performed a search, is looking through the results, and then looks back up at what he/she searched for. (One might think of a use case where the user didn't get the results they expected, and thus looked back to double-check their search, but the font is too small to read - this is what happened to me on a different page).

On the other hand, 1) might not only be difficult, but it could end up being somewhat strange to look at a text input field that has been inflated to be larger than other elements on the page (i.e. it might call unwanted attention to something meant to be subtle). 

Not sure what the right answer is here.
I think the right answer is to inflate the box the same way we inflate the text, i.e., to inflate any sizing of the box that depends on the metrics of the font.

That said, I'd recommend testing with HTML rather than with XUL; font inflation hasn't really been implemented for XUL yet, and the use for doing so is somewhat marginal.  (If we don't, we probably want to disable it a little better, though.)
tracking-fennec: --- → 11+
Priority: -- → P2
The Search input in about:config looks fine to me.  I bisected this to bug 706198,
which disabled font inflation in XUL documents.  Is there anything left to do
here for HTML?  Text input looks fine to me on various sites.  I noticed that
sometimes they don't auto-zoom when I tap them but that hasn't anything to do with
font-inflation does it?
Whiteboard: [readability], [font-inflation: form controls] → [readability], [font-inflation: form controls] WORKSFORME?
(In reply to Mats Palmgren [:mats] from comment #3)
> The Search input in about:config looks fine to me.  I bisected this to bug
> 706198,
> which disabled font inflation in XUL documents.  Is there anything left to do
> here for HTML?  Text input looks fine to me on various sites.  I noticed that
> sometimes they don't auto-zoom when I tap them but that hasn't anything to
> do with
> font-inflation does it?

I'm so sorry, mats. I bisected this to come up with bug 706198 as well, and then I forgot to post it in the bug. I apologize for wasting your time duplicating effort. ;)

At any rate, no, I think this has been completed by bug 706198 and should be marked as such.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Whiteboard: [readability], [font-inflation: form controls] WORKSFORME? → [readability], [font-inflation: form controls]
Attached image screenshot
This seems to have regressed sometime in the last few days. I'm seeing the following again now on the about:config menu on the latest trunk code on a Samsung Galaxy S2.

My guess would be that it has something to do with work that's been done lately on form controls...
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: