Downloading the add-on xpi from the builder shouldn't trigger the pop-up blocker

RESOLVED FIXED in Q2 2012

Status

P3
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: tbertels+bugzilla, Assigned: zalun)

Tracking

unspecified
Q2 2012
x86
Windows XP

Details

(Reporter)

Description

7 years ago
Nothing happens when clicking on download. The throbber comes and goes but I get nothing, not even an error in the error console.

If it helps, https://builder.addons.mozilla.org/xpi/check_download/[etc.] returns {"ready": true}
Hrm, I clicked the download button on one of my addons and it downloaded just fine. I had a popup blocker warning appear that I had to allow before it prompted for the download, but other than that, it seemed to work.
(Reporter)

Comment 2

7 years ago
My bad. I didn't notice that small faded icon in the url bar. Still used to the status bar icon.

However, it shouldn't trigger the pop-up blocking since there's a click (changing the bug summary).
Is there any way to fix this or is it gonna be a wontfix?
Summary: Can't download the add-on xpi from the builder (no error) → Downloading the add-on xpi from the builder shouldn't trigger the pop-up blocker
(Assignee)

Comment 3

7 years ago
I believe the only reason to keep popup was the "prevent from unloading" dialog window.
As we do not allow people to download xpi when changes are unsaved I guess it's no longer an issue. I'll check other options to trigger download deom JS.
(Assignee)

Updated

7 years ago
Assignee: nobody → zaloon
Priority: -- → P3
Target Milestone: --- → Q2 2012
(Assignee)

Comment 4

6 years ago
r? https://github.com/mozilla/FlightDeck/pull/151
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.