Closed Bug 720341 Opened 9 years ago Closed 9 years ago

Fix error downloading Test Pilot tests and fix the endless "Loading, please wait..." message

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird10+ fixed, thunderbird11+ fixed)

RESOLVED FIXED
Thunderbird 12.0
Tracking Status
thunderbird10 + fixed
thunderbird11 + fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
Fixing two issues in one patch here as its easiest and they were resolved together.

First:

Error: no element found
Source file: https://testpilot.mozillalabs.com/testcases/index-tb.json
Line: 1

This is generated because the xml parser thinks its getting a .html file not a plain text file, we can force this formatting server side or client side, but I've chosen server side for now.

Second:

When test pilot hasn't got any studies listed in index-tb.json (like is currently the case), it displays "Loading, please wait" in the list of studies forever. I've found this to be a bogus check for zero length on the list of studies.

I've checked this with Jono and he thinks it is fine to remove that check.
Attachment #590672 - Flags: review?(mconley)
Comment on attachment 590672 [details] [diff] [review]
The fix

Looks reasonable to me!
Attachment #590672 - Flags: review?(mconley) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/a049f0583298
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #590672 - Flags: approval-comm-beta+
Attachment #590672 - Flags: approval-comm-aurora+
Attachment #590672 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.