Last Comment Bug 720341 - Fix error downloading Test Pilot tests and fix the endless "Loading, please wait..." message
: Fix error downloading Test Pilot tests and fix the endless "Loading, please w...
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 12.0
Assigned To: Mark Banner (:standard8)
Depends on:
  Show dependency treegraph
Reported: 2012-01-23 04:19 PST by Mark Banner (:standard8)
Modified: 2012-01-24 13:19 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

The fix (1.99 KB, patch)
2012-01-23 04:19 PST, Mark Banner (:standard8)
mconley: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2012-01-23 04:19:48 PST
Created attachment 590672 [details] [diff] [review]
The fix

Fixing two issues in one patch here as its easiest and they were resolved together.


Error: no element found
Source file:
Line: 1

This is generated because the xml parser thinks its getting a .html file not a plain text file, we can force this formatting server side or client side, but I've chosen server side for now.


When test pilot hasn't got any studies listed in index-tb.json (like is currently the case), it displays "Loading, please wait" in the list of studies forever. I've found this to be a bogus check for zero length on the list of studies.

I've checked this with Jono and he thinks it is fine to remove that check.
Comment 1 User image Mike Conley (:mconley) 2012-01-23 07:10:33 PST
Comment on attachment 590672 [details] [diff] [review]
The fix

Looks reasonable to me!
Comment 2 User image Mark Banner (:standard8) 2012-01-24 02:09:13 PST
Checked in:

Note You need to log in before you can comment on or make changes to this bug.