Fix error downloading Test Pilot tests and fix the endless "Loading, please wait..." message

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 12.0

Thunderbird Tracking Flags

(thunderbird10+ fixed, thunderbird11+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 590672 [details] [diff] [review]
The fix

Fixing two issues in one patch here as its easiest and they were resolved together.

First:

Error: no element found
Source file: https://testpilot.mozillalabs.com/testcases/index-tb.json
Line: 1

This is generated because the xml parser thinks its getting a .html file not a plain text file, we can force this formatting server side or client side, but I've chosen server side for now.

Second:

When test pilot hasn't got any studies listed in index-tb.json (like is currently the case), it displays "Loading, please wait" in the list of studies forever. I've found this to be a bogus check for zero length on the list of studies.

I've checked this with Jono and he thinks it is fine to remove that check.
Attachment #590672 - Flags: review?(mconley)
(Assignee)

Updated

6 years ago
tracking-thunderbird10: --- → +
tracking-thunderbird11: --- → +
Comment on attachment 590672 [details] [diff] [review]
The fix

Looks reasonable to me!
Attachment #590672 - Flags: review?(mconley) → review+
(Assignee)

Comment 2

6 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/a049f0583298
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
(Assignee)

Updated

6 years ago
Attachment #590672 - Flags: approval-comm-beta+
Attachment #590672 - Flags: approval-comm-aurora+
(Assignee)

Updated

6 years ago
Attachment #590672 - Flags: approval-comm-beta+
(Assignee)

Comment 3

6 years ago
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/ba2f0d434933
http://hg.mozilla.org/releases/comm-beta/rev/9470da684c06
(Assignee)

Updated

6 years ago
status-thunderbird10: --- → fixed
status-thunderbird11: --- → fixed
You need to log in before you can comment on or make changes to this bug.