720346 - [thunderbird] Release automation for ESR

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

Tracking Thunderbird ESR automation work.  Our plan is to use the same approach as Firefox (tracked in bug 717106).

Comment 1

[[e-mail] (:bhearsum)]

John, is it fair to assign this to you? If not, throw it back.

Comment 2

[John Hopkins (:jhopkins)]

Created l10n-thunderbird-changesets-esr10 file: https://hg.mozilla.org/build/buildbot-configs/rev/40d2ef802424

Comment 3

[John Hopkins (:jhopkins)]

Created comm-esr10 release mozconfigs: https://hg.mozilla.org/build/buildbot-configs/rev/685f0b8937a2

Comment 4

[John Hopkins (:jhopkins)]

Created comm-esr10 l10n mozconfigs: https://hg.mozilla.org/build/buildbot-configs/rev/0659d5c787c6

Comment 5

[[e-mail] (:bhearsum)]

I added the following to rsyncd-mozilla-releases.exclude to make sure none of the esr builds go to external mirrors:
- thunderbird/releases/*esr*

Comment 6

[John Hopkins (:jhopkins)]

Attachment: mozilla/tools/patcher-configs new file

Comment 7

[John Hopkins (:jhopkins)]

Attachment: patch to support ESR

Comment 8

[John Hopkins (:jhopkins)]

Attachment: buildbot-configs patch to support ESR

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 594272 [details] [diff] [review]
patch to support ESR

Review of attachment 594272 [details] [diff] [review]:
-----------------------------------------------------------------

John, is this patch against a different repo/branch of buildbotcustom? It looks pretty similar to an older version of my buildbotcustom patch. I think it needs to be updated a bit, you'll want the hunk that passes --channel to update-verify-bump.pl, and maybe others from https://bug717106.bugzilla.mozilla.org/attachment.cgi?id=594246.

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 594274 [details] [diff] [review]
buildbot-configs patch to support ESR

Review of attachment 594274 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really know these files, so I think you should get someone else's review. lgtm though.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 594270 [details]
mozilla/tools/patcher-configs new file

>        <release>
>            <10.0esr>
>                prettyVersion   10.0esr
>                <platforms>
>                    linux-i686   20120129064000
>                    win32   20120129064235
>                    linux-x86_64   20120129064012
>                    mac   20120129063944
>                </platforms>
>                <exceptions>
>                    ja   linux-i686, linux-x86_64, win32
>                    ja-JP-mac   mac
>                </exceptions>
>                version   10.0esr
...
>                extension-version   10.0esr

Per the Firefox config, both these version numbers should be just "10.0".

r=me with that changed.

Comment 12

[John Hopkins (:jhopkins)]

(In reply to Mark Banner (:standard8) from comment #11)

Checking in mozEsr10-thunderbird-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/mozEsr10-thunderbird-branch-patcher2.cfg,v  <--  mozEsr10-thunderbird-branch-patcher2.cfg
initial revision: 1.1

Comment 13

[John Hopkins (:jhopkins)]

Attachment: buildbotcustom esr support

Comment 14

[John Hopkins (:jhopkins)]

Attachment: buildbot-configs esr support

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 595517 [details] [diff] [review]
buildbotcustom esr support

Review of attachment 595517 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +901,5 @@
> +            longVersion=releaseConfig.get('longVersion', None),
> +            oldLongVersion=releaseConfig.get('oldLongVersion', None),
> +            releaseChannel=releaseChannel,
> +        )
> +    

A nit. Could you remove trailing spaces from the line above?

Comment 16

[John Hopkins (:jhopkins)]

Comment on attachment 595518 [details] [diff] [review]
buildbot-configs esr support

Checked in to https://hg.mozilla.org/build/buildbot-configs/rev/546066e17bea

Comment 17

[John Hopkins (:jhopkins)]

Comment on attachment 595517 [details] [diff] [review]
buildbotcustom esr support

Addressed nit, checked in to https://hg.mozilla.org/users/gozer_mozillamessaging.com/buildbotcustom-thunderbird/rev/f371d2b001e0

Comment 18

[Mark Banner (:standard8)]

I just committed a couple more changes to try and get updates running:

http://hg.mozilla.org/build/tools/rev/580ba84f8bb2
http://hg.mozilla.org/build/buildbot-configs/rev/3bcf9ce65787

Comment 19

[Mark Banner (:standard8)]

Something we still need to fix is that on the update generation, the verify configs are still getting "betatest" rather than "esrtest". I had to fix that by manual change for the verify builders to pass correctly.

Comment 20

[[e-mail] (:bhearsum)]

(In reply to Mark Banner (:standard8) from comment #19)
> Something we still need to fix is that on the update generation, the verify
> configs are still getting "betatest" rather than "esrtest". I had to fix
> that by manual change for the verify builders to pass correctly.

You should be getting this for free if 'esr' is in the 'version' in the release config, per: http://mxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#5103

Is there anything else to do here, besides verify/fix the above?

Comment 21

[Mark Banner (:standard8)]

(In reply to Ben Hearsum [:bhearsum] from comment #20)
> (In reply to Mark Banner (:standard8) from comment #19)
> > Something we still need to fix is that on the update generation, the verify
> > configs are still getting "betatest" rather than "esrtest". I had to fix
> > that by manual change for the verify builders to pass correctly.
> 
> You should be getting this for free if 'esr' is in the 'version' in the
> release config, per:
> http://mxr.mozilla.org/build-central/source/buildbotcustom/process/factory.
> py#5103

So this bug is pre-Firefox automation, and I suspect we hadn't picked up buildbotcustom changes at the time, especially as we weren't generally upgrading our buildbot to the latest.

> Is there anything else to do here, besides verify/fix the above?

Looking at the logs of the patcher file:

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/tools/patcher-configs/mozEsr10-thunderbird-branch-patcher2.cfg&rev=HEAD&mark=1.12

We didn't need to do anything to get esr working right for the last couple of releases, especially the Firefox one, so I think this is all complete now.