Closed
Bug 72038
Opened 23 years ago
Closed 23 years ago
FTP listings never stop loading on Mac
Categories
(Core Graveyard :: Networking: FTP, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8.1
People
(Reporter: sfraser_bugs, Assigned: gordon)
Details
(Keywords: regression, Whiteboard: have patch, reviews, readyy for checkin)
Attachments
(1 file)
862 bytes,
patch
|
Details | Diff | Splinter Review |
The PR_Poll fixes on Mac broke FTP, such that directory listings (and maybe downloads) appear to never finish. The client never closes the data connection, with the result that the control connection waits for ever for the 'Transfer complete' notification. The part of the PR_Poll fix that broke this was the change to GetState(): @@ -1676,6 +1681,8 @@ { OTResult resultOT; + size_t availableData; - *readReady = fd->secret->md.readReady; + resultOT = OTCountDataBytes((EndpointRef)fd->secret->md.osfd, & availableData); + *readReady = fd->secret->md.readReady && (availableData > 0); *exceptReady = fd->secret->md.exceptReady; This changed the behaviour of PR_Poll/PR_Read such that clients would no longer see a 0-byte read to indicate that all the data on a socket had been read (which is what FTP relied on).
Reporter | ||
Updated•23 years ago
|
Keywords: regression
Target Milestone: --- → mozilla0.8.1
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
The attached patch fixed the bug with FTP, and does not regress the original GetState fix (bug 70408).
Comment 4•23 years ago
|
||
gordon, can you review please?
Review it? Simon and I wrote it. Can you try the patch and verify it works for you? I'll check it in this afternoon as soon as I get the necessary approvals.
Status: NEW → ASSIGNED
Comment 6•23 years ago
|
||
It would be better if you didn't use the old-style cast. Since it's a type with a simple name, you can use a construction-style cast. Other than that, sr=scc.
Updated•23 years ago
|
Whiteboard: have patch, reviews, readyy for checkin
Comment 7•23 years ago
|
||
Assuming this gets properly tested and it's deemed low risk we're approving this for 0.8.1.
Simon and I tested it, but I was hoping DougT was going to try some of his test cases on it as well. Doug?
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•2 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•