Context menu in Compose Window has non-functional and unrelated options

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Message Reader UI
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: squib)

Tracking

({regression})

11 Branch
Thunderbird 13.0
regression

Thunderbird Tracking Flags

(thunderbird11+ fixed, thunderbird12 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 590783 [details]
A demonstration of the problem

Steps to reproduce:

1)  Open up an email message in a new window (right click on the message, choose "Open Message in New Window")
2)  Right click on the message text

What happens?

A massive context menu comes up, with options for doing things that make no sense in the context of the message ("Play", "Mute", "Unmute", "Reply to Newsgroup", etc).

What's expected?

A smaller list should appear, with options that only make sense in the context of the message I'm viewing.

See attachment.
(Assignee)

Comment 1

6 years ago
Hm, that's my fault. PageMenu.jsm isn't defined in the standalone message window. The various PageMenu bits[1] should probably be moved to nsContextMenu.js?

[1] http://mxr.mozilla.org/comm-central/search?string=PageMenu&find=mail%2Fbase%2F*&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Blocks: 680192
tracking-thunderbird11: --- → ?
Keywords: regression
(Assignee)

Comment 2

6 years ago
Note also that (I think) the way this is handled currently, HTML messages could theoretically add context menu items (but no Javascript code can execute). Maybe we should disallow that, since it's not very useful without JS...
(Assignee)

Updated

6 years ago
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Duplicate of this bug: 724320
(Assignee)

Comment 4

6 years ago
Created attachment 594509 [details] [diff] [review]
Fix this

This should fix things. Let me know if you want automated tests for it.
Attachment #594509 - Flags: review?(mconley)

Updated

6 years ago
Duplicate of this bug: 724326

Updated

6 years ago
OS: Windows 7 → All

Updated

6 years ago
Hardware: x86 → All

Comment 6

6 years ago
(In reply to Jim Porter (:squib) from comment #4)
> This should fix things.
Yes, it does, I can confirm that this patch fixes all issues I have with right click menu on standalone window with Thunderbird 11. :-)
(Reporter)

Comment 7

6 years ago
Hey Jim,

Work-week swamped me, and I couldn't get any reviews done.  I'll have this reviewed tomorrow.

-Mike
(Reporter)

Comment 8

6 years ago
Comment on attachment 594509 [details] [diff] [review]
Fix this

Review of attachment 594509 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

If I could have one more thing, it'd be a Mozmill test for this, if you have the cycles.  If not, maybe file a bug for one.
Attachment #594509 - Flags: review?(mconley) → review+
(Assignee)

Comment 9

6 years ago
I'd really rather figure out a way to make any JS error trigger a Mozmill failure. That probably would have caught this. (Otherwise, we run the risk of explicitly testing *everything*, which sounds nice until you think about what "everything" means...)
(Reporter)

Comment 10

6 years ago
(In reply to Jim Porter (:squib) from comment #9)
> I'd really rather figure out a way to make any JS error trigger a Mozmill
> failure. That probably would have caught this. (Otherwise, we run the risk
> of explicitly testing *everything*, which sounds nice until you think about
> what "everything" means...)

Touché! :)
(Assignee)

Comment 11

6 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/ebd6300d9dfc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Comment 12

6 years ago
Comment on attachment 594509 [details] [diff] [review]
Fix this

We should definitely take this for beta and aurora, since this totally breaks the context menu in the standalone window.
Attachment #594509 - Flags: approval-comm-beta?
Attachment #594509 - Flags: approval-comm-aurora?
Attachment #594509 - Flags: approval-comm-beta?
Attachment #594509 - Flags: approval-comm-beta+
Attachment #594509 - Flags: approval-comm-aurora?
Attachment #594509 - Flags: approval-comm-aurora+
Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/0dd0060b9685
http://hg.mozilla.org/releases/comm-beta/rev/f353ac3ffbf7
status-thunderbird11: --- → fixed
status-thunderbird12: --- → fixed
tracking-thunderbird11: ? → +
You need to log in before you can comment on or make changes to this bug.