Closed Bug 720420 Opened 12 years ago Closed 12 years ago

Context menu in Compose Window has non-functional and unrelated options

Categories

(Thunderbird :: Message Reader UI, defect)

11 Branch
defect
Not set
normal

Tracking

(thunderbird11+ fixed, thunderbird12 fixed)

RESOLVED FIXED
Thunderbird 13.0
Tracking Status
thunderbird11 + fixed
thunderbird12 --- fixed

People

(Reporter: mconley, Assigned: squib)

References

Details

(Keywords: regression)

Attachments

(2 files)

Steps to reproduce:

1)  Open up an email message in a new window (right click on the message, choose "Open Message in New Window")
2)  Right click on the message text

What happens?

A massive context menu comes up, with options for doing things that make no sense in the context of the message ("Play", "Mute", "Unmute", "Reply to Newsgroup", etc).

What's expected?

A smaller list should appear, with options that only make sense in the context of the message I'm viewing.

See attachment.
Hm, that's my fault. PageMenu.jsm isn't defined in the standalone message window. The various PageMenu bits[1] should probably be moved to nsContextMenu.js?

[1] http://mxr.mozilla.org/comm-central/search?string=PageMenu&find=mail%2Fbase%2F*&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Blocks: 680192
Keywords: regression
Note also that (I think) the way this is handled currently, HTML messages could theoretically add context menu items (but no Javascript code can execute). Maybe we should disallow that, since it's not very useful without JS...
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attached patch Fix thisSplinter Review
This should fix things. Let me know if you want automated tests for it.
Attachment #594509 - Flags: review?(mconley)
OS: Windows 7 → All
Hardware: x86 → All
(In reply to Jim Porter (:squib) from comment #4)
> This should fix things.
Yes, it does, I can confirm that this patch fixes all issues I have with right click menu on standalone window with Thunderbird 11. :-)
Hey Jim,

Work-week swamped me, and I couldn't get any reviews done.  I'll have this reviewed tomorrow.

-Mike
Comment on attachment 594509 [details] [diff] [review]
Fix this

Review of attachment 594509 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

If I could have one more thing, it'd be a Mozmill test for this, if you have the cycles.  If not, maybe file a bug for one.
Attachment #594509 - Flags: review?(mconley) → review+
I'd really rather figure out a way to make any JS error trigger a Mozmill failure. That probably would have caught this. (Otherwise, we run the risk of explicitly testing *everything*, which sounds nice until you think about what "everything" means...)
(In reply to Jim Porter (:squib) from comment #9)
> I'd really rather figure out a way to make any JS error trigger a Mozmill
> failure. That probably would have caught this. (Otherwise, we run the risk
> of explicitly testing *everything*, which sounds nice until you think about
> what "everything" means...)

Touché! :)
Checked in: http://hg.mozilla.org/comm-central/rev/ebd6300d9dfc
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Comment on attachment 594509 [details] [diff] [review]
Fix this

We should definitely take this for beta and aurora, since this totally breaks the context menu in the standalone window.
Attachment #594509 - Flags: approval-comm-beta?
Attachment #594509 - Flags: approval-comm-aurora?
Attachment #594509 - Flags: approval-comm-beta?
Attachment #594509 - Flags: approval-comm-beta+
Attachment #594509 - Flags: approval-comm-aurora?
Attachment #594509 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.