720458 - [One Mozilla] Help Test Tabzilla on major Mozilla Websites

Status: RESOLVED WONTFIX

(Websites :: Tabzilla, defect)

Description

[mcbmoz]

Opening this bug for team leads to assign a website dev to help test the implementation of the universal tab, Tabzilla on major Mozilla websites.

Steven G. is preparing the last bits for you over on:

Implementation Bug 629699
Fixes to /firefox site's CSS needed for implementation Bug 720370
 

Follow project on Github @ https://github.com/mozilla/tabzilla

Note: this isn't to launch the tab on your sites (unless you want to), it's for us to make sure that the technical solution meets your needs and to help us find edge cases we may have missed.

Thanks for your help!

Comment 1

[James Long (:jlongster)]

I'm most likely the best candidate for this, but I do have a lot on my plate this week. If Steven can walk me through everything, I can help test it.

Comment 2

[Steven Garrity [:sgarrity]]

To clarify my plan a bit, my goal is to have the minor (invisible) changes in the template/css required to add the tab to mozilla.org and mozilla.org/firefox rolled out today with the 1.3 release (this is addressed in Bug 720370).

Then, we'll have what we need in place to implement the actual tab on mozilla.org/firefox trunk for testing with a real launch later in the week, or with 1.4 next Tuesday.

Feedback is encouraged.

Comment 3

[David Ascher (:davida)]

I'm not sure where you want feedback, but so far the only thing i've noticed is I expected the downward-pointing chevron to point up when the menu is toggled on.  Seems like something that could be done w/ some flair w/ some CSS3 animation maybe?

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Here is my early feedback looking at the code:
- there is a couple of urls to mozilla.org with en-US in the code, ideally don't hardcode the locale code and let mozilla.org do the locale detection itself
- the chunk of html inserted with innerHTML is also hardcoded in the javascript file, it would be good to be able:
 - pass a variable indicating the language of the template we want to have for this menu
 - preprocess the js file server-side as we do it for download.js to benefit from mozilla.org l10n framework to return a localized header to the external site

ex:
<script src="//www.mozilla.org/tabzilla/media/js/tabzilla.js?lang=de"></script>

and in the preprocessed .js file:

+ '<li><a href="http://www.mozilla.org/contribute/"><?=___('Learn more')?></a></li>'

I also think we may want to be able to have variations of the html depending on the market we target. For example I can imagine Mozilla China or Japan wanting to promote regional links (promotional campaigns for example) or messages in the panel that wouldn't be for other regions, similarily we could have similar requests from marketing for PR and locale-specific marketing campaigns (ex: the recent De Todos Para Todos campaign in Spanish or localized newsletters.

(I can probably experiment on this in the weeks to come if needed)

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

On a non-l10n related feedback, we include a version of jquery from a Google CDN in the script, we may have to ask legal if this is OK policy-wise.

Comment 6

[Steven Garrity [:sgarrity]]

Thanks for the feedback Pascal. Basically, there's no l10n at all yet, but your suggestion of pre-processing is probably the right track. I'd rather do it in/on Bedrock rather than the current .org stack though.

(In reply to Pascal Chevrel:pascalc from comment #5)
> On a non-l10n related feedback, we include a version of jquery from a Google
> CDN in the script, we may have to ask legal if this is OK policy-wise.

We did this as a temporary hack because the mozilla CDN doesn't seem to allow HTTPS:

http://mozcom-cdn.mozilla.net/tabzilla/media/js/tabzilla.js
 vs. 
https://mozcom-cdn.mozilla.net/tabzilla/media/js/tabzilla.js

Should we file another bug for this?

Comment 7

[Steven Garrity [:sgarrity]]

(In reply to David Ascher (:davida) from comment #3)
> I'm not sure where you want feedback, but so far the only thing i've noticed
> is I expected the downward-pointing chevron to point up when the menu is
> toggled on.  Seems like something that could be done w/ some flair w/ some
> CSS3 animation maybe?

This was in the plans, and has since been implemented. Thanks (and yets, such feedback is welcome here).

Comment 8

[James Long (:jlongster)]

It's worth noting that the same translations that you get with the ___ function will be available in bedrock. I just integrated the .lang files so if needed, we can translate it and we can easily port the translations.

It's best to wait if possible though, so that we can focus on the new infrastructure.

Comment 9

[Chris More [:cmore]]

I scanned 187 of our production Mozilla-owned websites and found the following list that should contain the new or old tab:

addons.mozilla.org
affiliates.mozilla.org
air.mozilla.org
blog.mozilla.com
developer.mozilla.org
dnt.mozilla.org
donate.mozilla.org
learningfreedomandtheweb.org
mozilla.lt
mozilla.pt
mozilla.org
nightly.mozilla.org
onemozilla.org
quality.mozilla.org
spark.mozilla.org
support.mozillamessaging.com
support.mozilla.org

If you know a site that has the old tab on it and it is not on the list above, please let me know. Since the implementation of the old tab was not standardized, it is not easy to scan all websites for it.

Comment 10

[Pascal Finette [:pfinette]]

(In reply to Chris More [:cmore] from comment #9)
> I scanned 187 of our production Mozilla-owned websites and found the
> following list that should contain the new or old tab:
> 
> addons.mozilla.org
> affiliates.mozilla.org
> air.mozilla.org
> blog.mozilla.com
> developer.mozilla.org
> dnt.mozilla.org
> donate.mozilla.org
> learningfreedomandtheweb.org
> mozilla.lt
> mozilla.pt
> mozilla.org
> nightly.mozilla.org
> onemozilla.org
> quality.mozilla.org
> spark.mozilla.org
> support.mozillamessaging.com
> support.mozilla.org
> 
> If you know a site that has the old tab on it and it is not on the list
> above, please let me know. Since the implementation of the old tab was not
> standardized, it is not easy to scan all websites for it.

+ mozillalabs.com
+ browserid.org
+ design-challenge.mozillalabs.com
+ testpilot.mozillalabs.com
+ gaming.mozillalabs.com

Comment 11

[James Socol [:jsocol, :james]]

(In reply to Chris More [:cmore] from comment #9)
> I scanned 187 of our production Mozilla-owned websites and found the
> following list that should contain the new or old tab:

> support.mozilla.org

Support has the old tab, but I'm not entirely sure what "should contain the new *or* old tab" means.

Comment 12

[Chris More [:cmore]]

> > 
> > If you know a site that has the old tab on it and it is not on the list
> > above, please let me know. Since the implementation of the old tab was not
> > standardized, it is not easy to scan all websites for it.
> 
> + mozillalabs.com
> + browserid.org
> + design-challenge.mozillalabs.com
> + testpilot.mozillalabs.com
> + gaming.mozillalabs.com

Pascal: I don't see the legacy Mozilla tab on the sites you mentioned above. We are specifically looking for sites that implemented the old tab to be converted over to tabzilla. Changing sites that have no tab and should have One Mozilla assets like tabzilla was out of scope of my scan unless I am missing something from your list.

Let me know if I am wrong. :)

Comment 13

[Pascal Finette [:pfinette]]

(In reply to Chris More [:cmore] from comment #12)
> Pascal: I don't see the legacy Mozilla tab on the sites you mentioned above.
> We are specifically looking for sites that implemented the old tab to be
> converted over to tabzilla. Changing sites that have no tab and should have
> One Mozilla assets like tabzilla was out of scope of my scan unless I am
> missing something from your list.

Ah - my bad!

Comment 14

[Kohei Yoshino [:kohei]]

As you might know, Bug 1151579 has replaced Tabzilla with a static Mozilla tab. The old assets are still available, but no site is probably using it. Closing all Tabzilla-related open bugs at this moment.