Closed Bug 720666 Opened 12 years ago Closed 12 years ago

Implement workaround for namespace module until weak maps are fixed

Categories

(Add-on SDK Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: irakli, Assigned: irakli)

References

Details

Attachments

(1 file)

We need to implement temporary workaround until Bug 655297 will land to stable firefox to continue using namespace module with our APIs.
Assignee: nobody → rFobic
See Also: → 673468
Attachment #591064 - Flags: review?(poirot.alex)
Comment on attachment 591064 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/330

Looks good. Works on Windows FF9 and FF12.
I verified if it was introducing a leak by testing with memory reporters, but it does not!
Attachment #591064 - Flags: review?(poirot.alex) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b19bfb835738188e7282f8efe264510c9d3959a0
Merge pull request #330 from Gozala/bug/workaround-weakmaps.720666

fix Bug 720666 - Implement workaround for namespace module until weak maps are fixed r=@ochameau
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: