Closed Bug 720698 Opened 8 years ago Closed 8 years ago

URL bar on awesome screen should not have a white outline

Categories

(Firefox for Android :: General, defect)

11 Branch
x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox12 --- verified
firefox13 --- verified

People

(Reporter: padamczyk, Assigned: sriram)

Details

(Keywords: polish)

Attachments

(2 files)

See screenshot of issue.
The URL bar on the awesome screen should not have a white outline, nor should there be a shadow coming from the top and bottom curves of the edges.
It should blend perfectly into the background and appear like the input field is chiseled out of the background, similar to how it appears on start page, please use the same 9 slice input field graphic from the start page.
Assignee: nobody → sriram
Attached patch PatchSplinter Review
This patch moves the code to constructor, as honeycomb and ics can only take it from the context. The textColorHighlight is obtained on all devices with this fix.
Attachment #591265 - Flags: review?(mark.finkle)
Attachment #591265 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/5b86c60b8461
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Sriram, request approval for aurora
Comment on attachment 591265 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
The honeycomb and ICS will have a white color as an outline for the url-bar and the selected tabs. The focus on the edit-text (url-bar) will not be known clearly.

Testing completed (on m-c, etc.): Landed on m-c on 01/28
Testing done on honeycomb and ICS devices.

Risk to taking this patch (and alternatives if risky):
Risk is very low. This is the minimalistic change required to fix this problem on those devices.
Attachment #591265 - Flags: approval-mozilla-aurora?
Attachment #591265 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-04)
Aurora Fennec 12.0a2 (2012-03-04)
Device: Galaxy Nexus (Android 4.0)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.