Last Comment Bug 720769 - Enable nsTransferable in Gonk backend
: Enable nsTransferable in Gonk backend
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-24 11:07 PST by Michael Wu [:mwu]
Modified: 2012-01-26 13:52 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Enable nsTransferable (1.85 KB, patch)
2012-01-24 11:07 PST, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2012-01-24 11:07:12 PST
Created attachment 591183 [details] [diff] [review]
Enable nsTransferable

This avoids a crash in cases where the code expects this to be available. In particular - a null pointer dereference in http://hg.mozilla.org/mozilla-central/file/c3643d492d68/content/base/src/nsContentAreaDragDrop.cpp#l679
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-24 22:49:39 PST
Comment on attachment 591183 [details] [diff] [review]
Enable nsTransferable

Seems like http://hg.mozilla.org/mozilla-central/file/c3643d492d68/content/base/src/nsContentAreaDragDrop.cpp#l679 probably wants to null check the transferrable, but if this gets us closer to drag 'n drop and fixes the crash too, great.
Comment 3 Ed Morley [:emorley] 2012-01-25 18:07:19 PST
https://hg.mozilla.org/mozilla-central/rev/6a64b8fcffaf

Note You need to log in before you can comment on or make changes to this bug.