720782 - If we dont_build a platform on project_branches we should not add testers for it

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[Armen [:armenzg]]

After looking at this attachment [1] and knowing that we want less builders since it causes trouble [2].

I believe we should be smart and disable test builders if there are no build builders for that branch.

This is not urgent but worth taking into consideration when working on bug 633054.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=591117&action=edit
[2] bug 712244.

Comment 1

[Armen [:armenzg]]

Attachment: remove testing builders

This is while we don't do it automatically.

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 591209 [details] [diff] [review]
remove testing builders

I've already landed my patch to turn off the debug builds for the profiling branch. If you wouldn't mind adding "'enable_debug_unittests': False" to the profiling debug platforms before you commit, I would appreciate it. 

No sense creating those builders unnecessarily, as you said.

Comment 3

[Armen [:armenzg]]

Comment on attachment 591209 [details] [diff] [review]
remove testing builders

Added "profiling" as well:
http://hg.mozilla.org/build/buildbot-configs/rev/0c1ac1eef9e8

Comment 4

[[e-mail] (:bhearsum)]

This landed in production today.

Comment 5

[Chris Cooper [:coop] (he/him)]

Armen: anything left to do here?

Comment 6

[Armen [:armenzg]]

Yes.
If we don't build on a platform we should not create the test builders for it.
My patch was to address an instance of such scenario (no builder but there were testers for it), hence, all the work is still remaining.

Comment 7

[[e-mail] (:bhearsum)]

Buildbot is on life support at this point, probably not worth fixing.

Comment 8

[Armen [:armenzg]]

We test to prevent this:
http://hg.mozilla.org/build/buildbot-configs/file/52c54a6e006c/test/test_no_testers_without_builders.py