720800 - Properly handle navigation commands in b2g

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Currently these aren't supported in B2G, but we need to figure out how they should be handled.

Comment 1

[Jonathan Griffin (:jgriffin)]

I think these should be handled by causing navigation of the primary browser element in B2G, not the browser-in-a-browser iframe.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Agreed, but there is no concept of window/browser history in b2g, since everything is handled by hiding/showing divs on a dynamic page. We'll have to simulate the "back" button on the phone in order to go back instead of using the history. 

I'm not sure how we can handle going forward with this since there is no concept of going forward using the device buttons. We might be able to maintain a stack of sent commands and pop & store them as we go back, and push & execute them as we go forward. 

Also the execution of navigate has to rely on the appManager, since it manages the launching of apps. That seems to be something we do with execute_script, and we can add it to the marionette client as a helper method.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

oh um, s/appManager/WindowManager

And from looking at some of the code, the "back" button functionality can be simulated by sending a 'keyup' event of DOM_VK_ESCAPE to the window. After a bit of googling, it seems that back is mapped to escape with android phones so I think we can safely add this to the marionette actor instead of the client.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Friendly fallout from Bug 746031 resulted in navigation working correctly in b2g. It now loads whatever page you requested and waits for the dom to be ready. Back and Forward commands work, as well.