Last Comment Bug 720853 - Need read barrier for atom table
: Need read barrier for atom table
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: [PTO to Dec5] Bill McCloskey (:billm)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-24 15:01 PST by [PTO to Dec5] Bill McCloskey (:billm)
Modified: 2012-01-25 07:08 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.12 KB, patch)
2012-01-24 15:01 PST, [PTO to Dec5] Bill McCloskey (:billm)
luke: review+
Details | Diff | Splinter Review

Description [PTO to Dec5] Bill McCloskey (:billm) 2012-01-24 15:01:06 PST
Created attachment 591287 [details] [diff] [review]
patch

The atom table basically holds weak pointers, so it needs a read barrier. This is it.
Comment 1 Luke Wagner [:luke] 2012-01-24 15:41:23 PST
Comment on attachment 591287 [details] [diff] [review]
patch

As discussed, could you move/merge TaggedPointerEntry into jsatom.h?
Comment 2 [PTO to Dec5] Bill McCloskey (:billm) 2012-01-24 18:34:55 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/a23e8635383a
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-01-25 07:08:51 PST
https://hg.mozilla.org/mozilla-central/rev/a23e8635383a

Note You need to log in before you can comment on or make changes to this bug.