Closed Bug 720975 Opened 8 years ago Closed 8 years ago

Switch to vertical layout only when the window width < 550px

Categories

(DevTools :: Style Editor, defect)

x86
All
defect
Not set
normal

Tracking

(firefox11 verified)

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- verified

People

(Reporter: paul, Assigned: paul)

Details

(Whiteboard: [qa+][testday-20120203][qa!:11])

Attachments

(2 files)

To avoid some frustration when the window is large enough to get the horizontal view.
Attached patch patch v1Splinter Review
Attachment #591456 - Flags: review?(cedricv)
Attachment #591456 - Flags: review?(cedricv) → feedback?(cedricv)
Whiteboard: [addToFirefox11]
Attachment #591456 - Flags: review?(mihai.sucan)
Comment on attachment 591456 [details] [diff] [review]
patch v1

Review of attachment 591456 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thanks Paul!
Attachment #591456 - Flags: review?(mihai.sucan) → review+
Attachment #591456 - Flags: feedback?(cedricv) → feedback+
Whiteboard: [addToFirefox11] → [land-in-fx-team][addToFirefox11]
Assignee: nobody → paul
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/f0f0451c75eb
Whiteboard: [land-in-fx-team][addToFirefox11] → [fixed-in-fx-team][addToFirefox11]
https://hg.mozilla.org/mozilla-central/rev/f0f0451c75eb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][addToFirefox11] → [addToFirefox11]
Target Milestone: --- → Firefox 12
Comment on attachment 591456 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): Not a regression, new feature.
User impact if declined: Bad UX. The StyleEditor UI will constantly be reorganized on resize.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): low. Only CSS.
Attachment #591456 - Flags: approval-mozilla-aurora?
Comment on attachment 591456 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.
Attachment #591456 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa+]
Seems to work on Linux-x86_64 with
* 11.0b1 as opposed to Nightly 20120125.
* Aurora Gecko/20120202 Firefox/12.0a2 as opposed to Gecko/20120101 Firefox/11.0a2

However, on my system it means that the file list can be much larger than the editor while there is a lot of blank space. If the text was larger, even less of it would fit, and/or more horizontal scrolling would appear. Do the text sizes depend on anything, and if yes, what about deriving the width from them? See also bug 719457.
Whiteboard: [qa+] → [qa+][testday-20120203]
(In reply to Aleksej [:Aleksej] from comment #9)
> Seems to work on Linux-x86_64 with
> * 11.0b1 as opposed to Nightly 20120125.
> * Aurora Gecko/20120202 Firefox/12.0a2 as opposed to Gecko/20120101
> Firefox/11.0a2
> 
> However, on my system it means that the file list can be much larger than
> the editor while there is a lot of blank space.

"blank space"?

> If the text was larger,

Which text?

> even less of it would fit, and/or more horizontal scrolling would appear. Do the
> text sizes depend on anything, and if yes, what about deriving the width
> from them? See also bug 719457.

Sorry - I am not sure to understand. Can you open a new bug with screenshots?
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified using Firefox 11 beta 1 on Win 7, Ubuntu 11.10 and Mac OS X 10.6 that the Style Editor switches to vertical only when the width  is < 550 px.
Whiteboard: [qa+][testday-20120203] → [qa+][testday-20120203][qa!:11]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.