720975 - Switch to vertical layout only when the window width < 550px

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Paul Rouget [:paul]]

To avoid some frustration when the window is large enough to get the horizontal view.

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 591456 [details] [diff] [review]
patch v1

Review of attachment 591456 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thanks Paul!

Comment 3

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/f0f0451c75eb

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f0f0451c75eb

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 591456 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): Not a regression, new feature.
User impact if declined: Bad UX. The StyleEditor UI will constantly be reorganized on resize.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): low. Only CSS.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 591456 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.

Comment 7

[Paul Rouget [:paul]]

Attachment: Patch v1 - rebased for Aurora

Comment 8

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e1d6266b5a2c

Comment 9

[[:Aleksej]]

Seems to work on Linux-x86_64 with
* 11.0b1 as opposed to Nightly 20120125.
* Aurora Gecko/20120202 Firefox/12.0a2 as opposed to Gecko/20120101 Firefox/11.0a2

However, on my system it means that the file list can be much larger than the editor while there is a lot of blank space. If the text was larger, even less of it would fit, and/or more horizontal scrolling would appear. Do the text sizes depend on anything, and if yes, what about deriving the width from them? See also bug 719457.

Comment 10

[Paul Rouget [:paul]]

(In reply to Aleksej [:Aleksej] from comment #9)
> Seems to work on Linux-x86_64 with
> * 11.0b1 as opposed to Nightly 20120125.
> * Aurora Gecko/20120202 Firefox/12.0a2 as opposed to Gecko/20120101
> Firefox/11.0a2
> 
> However, on my system it means that the file list can be much larger than
> the editor while there is a lot of blank space.

"blank space"?

> If the text was larger,

Which text?

> even less of it would fit, and/or more horizontal scrolling would appear. Do the
> text sizes depend on anything, and if yes, what about deriving the width
> from them? See also bug 719457.

Sorry - I am not sure to understand. Can you open a new bug with screenshots?

Comment 11

[[:Aleksej]]

(In reply to Paul Rouget [:paul] from comment #10)
https://bugzilla.mozilla.org/show_bug.cgi?id=723909
https://bugzilla.mozilla.org/show_bug.cgi?id=723912

Comment 12

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified using Firefox 11 beta 1 on Win 7, Ubuntu 11.10 and Mac OS X 10.6 that the Style Editor switches to vertical only when the width  is < 550 px.