Closed Bug 720984 Opened 8 years ago Closed 8 years ago

contentAreaUtils.js: getTargetFile leaks gDownloadLastDir into the global scope

Categories

(Toolkit :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #591416 - Flags: review?(gavin.sharp)
Attachment #591416 - Flags: review?(gavin.sharp) → review+
This made xpcshell tests fail:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/content/tests/unit/test_privatebrowsing_downloadLastDir_c.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/content/tests/unit/test_privatebrowsing_downloadLastDir_c.js:128 | ReferenceError: gDownloadLastDir is not defined - See following stack:

Backed out of inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d6243b6fb4
https://hg.mozilla.org/mozilla-central/rev/b0d7705cd271
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.