Remove javascript:/data: URIs may be incompatible test

RESOLVED FIXED in 2012-08-09

Status

--
minor
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: eviljeff, Assigned: basta)

Tracking

unspecified
2012-08-09

Details

(Reporter)

Description

7 years ago
Any instance of a hard coded "data:" uri in addon source code throws the following warning:

"Notice: javascript:/data: URIs may be incompatible with Firefox 6.

Loading 'javascript:' and 'data:' URIs through the location bar may no longer work as expected in Firefox 6. If you load these types of URIs, please test your add-on on the latest Firefox 6 builds, or refer to https://bugzilla.mozilla.org/show_bug.cgi?id=656433 for more information."

I can't recall seeing this as a true positive in any addons, at least not recently.  I recommend the rule be removed to reduce unnecessary warnings.
I think Kris filed this same bug some time ago.
I was thinking of bug 671387, but that's slightly different.
+1

I've never seen (nor can I imagine) a true positive for this, and even with the changes in bug 671387 this is still generating quite a lot of noise. The only way an add-on could even conceivably be affected by this would be to inject a URL into the urlbar and manually submit it, and an add-on that did that would be so broken that there would be little point in nitpicking over the principal that said URL gets loaded with.
Argh! Please make this die!
Should be easy to just remove the test.
Assignee: nobody → mattbasta
Target Milestone: --- → 2012-08-02
Target Milestone: 2012-08-02 → 2012-08-09
(Assignee)

Comment 6

6 years ago
Removed:

https://github.com/mozilla/amo-validator/commit/56292a65e7518a85691de9c82e717cd687137308
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.