720989 - Remove javascript:/data: URIs may be incompatible test

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Andrew Williamson [:eviljeff]]

Any instance of a hard coded "data:" uri in addon source code throws the following warning:

"Notice: javascript:/data: URIs may be incompatible with Firefox 6.

Loading 'javascript:' and 'data:' URIs through the location bar may no longer work as expected in Firefox 6. If you load these types of URIs, please test your add-on on the latest Firefox 6 builds, or refer to https://bugzilla.mozilla.org/show_bug.cgi?id=656433 for more information."

I can't recall seeing this as a true positive in any addons, at least not recently.  I recommend the rule be removed to reduce unnecessary warnings.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

I think Kris filed this same bug some time ago.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I was thinking of bug 671387, but that's slightly different.

Comment 3

[Kris Maglione [:kmag]]

+1

I've never seen (nor can I imagine) a true positive for this, and even with the changes in bug 671387 this is still generating quite a lot of noise. The only way an add-on could even conceivably be affected by this would be to inject a URL into the urlbar and manually submit it, and an add-on that did that would be so broken that there would be little point in nitpicking over the principal that said URL gets loaded with.

Comment 4

[Kris Maglione [:kmag]]

Argh! Please make this die!

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Should be easy to just remove the test.

Comment 6

[Matt Basta [:basta]]

Removed:

https://github.com/mozilla/amo-validator/commit/56292a65e7518a85691de9c82e717cd687137308