721021 - Port |Bug 593321 - Opening saved .EML with empty subject has wrong window title|

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

We should add the following nsDummyMsgHeader properties to match TB's msgHdrViewOverlay.js (and because it makes sense, of course ;-)):

* getUint32Property
* setUint32Property
* subject (bug 593321)
* mime2DecodedSubject

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: Comment 3]

Comment 2

[Karsten Düsterloh]

Comment on attachment 591478 [details] [diff] [review]
patch [Checkin: Comment 3]

> {
>   mProperties : new Array,
>   getStringProperty : function(aProperty) {
>     return this.mProperties[aProperty];
>   },
>   setStringProperty : function(aProperty, aVal) {
>     this.mProperties[aProperty] = aVal;
>   },
>+  getUint32Property : function(aProperty) {
>+    if (aProperty in this.mProperties)
>+      return parseInt(this.mProperties[aProperty]);
>+    return 0;
>+  },
>+  setUint32Property: function(aProperty, aVal) {
>+    this.mProperties[aProperty] = aVal.toString();
>+  },

Bah. Please put the { on their own line (and please fix that for the *StringProperty functions as well, while touching this area).
Also, all other elements of this prototype have a space before the :, hence setUint32Property should have as well (although, strictly speaking, this is "wrong").

r/moa=me only with these changes.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 591478 [details] [diff] [review]
patch [Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/e65f0736efe7