The default bug view has changed. See this FAQ.

update to latest graphite2 code from upstream

RESOLVED FIXED in mozilla12

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx.relnote.13])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 591491 [details] [diff] [review]
update gfx/graphite2 to upstream rev.907 (changeset 58cb0cd37bf2)

We should take a graphite2 update to benefit from recent bugfixes. This is pretty much a drop-in replacement for what we currently have; there are no API changes, etc., that affect our integration, just a couple of Makefile changes due to revised #define's for compile-time options that we select.

John, not sure what kind of "review" you think this needs, being essentially just a new code drop; rubber-stamp?
Attachment #591491 - Flags: review?(jdaggett)
(Assignee)

Comment 1

5 years ago
Btw, this is expected to fix the build warnings we've been seeing on Windows.
Blocks: 712120

Comment 2

5 years ago
Jonathan, I won't have time to review this until later next week so if you think this needs to land before the merge, feel free to switch the review to roc if he has lots of free cycles. ;)
Comment on attachment 591491 [details] [diff] [review]
update gfx/graphite2 to upstream rev.907 (changeset 58cb0cd37bf2)

Review of attachment 591491 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy to rubber-stamp this.
Attachment #591491 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 4

5 years ago
Bumped to upstream rev 911:a697cecbaddd, and pushed to inbound, carrying forward rs=roc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea57c1351cc
Target Milestone: --- → mozilla12
Depends on: 721466
https://hg.mozilla.org/mozilla-central/rev/3ea57c1351cc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 6

5 years ago
VC2010 SP1 PGO build fails at json.cpp
I fix it by adding:
#include <stdio.h>
(Assignee)

Comment 7

5 years ago
(In reply to Yuan Pengfei from comment #6)
> VC2010 SP1 PGO build fails at json.cpp
> I fix it by adding:
> #include <stdio.h>

See bug 721466.
(Assignee)

Updated

5 years ago
Blocks: 712587

Updated

5 years ago
Whiteboard: [gfx.relnote.13]
Blocks: 746975
Depends on: 631479
You need to log in before you can comment on or make changes to this bug.