721068 - update to latest graphite2 code from upstream

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: update gfx/graphite2 to upstream rev.907 (changeset 58cb0cd37bf2)

We should take a graphite2 update to benefit from recent bugfixes. This is pretty much a drop-in replacement for what we currently have; there are no API changes, etc., that affect our integration, just a couple of Makefile changes due to revised #define's for compile-time options that we select.

John, not sure what kind of "review" you think this needs, being essentially just a new code drop; rubber-stamp?

Comment 1

[Jonathan Kew [:jfkthame]]

Btw, this is expected to fix the build warnings we've been seeing on Windows.

Comment 2

[John Daggett (:jtd)]

Jonathan, I won't have time to review this until later next week so if you think this needs to land before the merge, feel free to switch the review to roc if he has lots of free cycles. ;)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 591491 [details] [diff] [review]
update gfx/graphite2 to upstream rev.907 (changeset 58cb0cd37bf2)

Review of attachment 591491 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy to rubber-stamp this.

Comment 4

[Jonathan Kew [:jfkthame]]

Bumped to upstream rev 911:a697cecbaddd, and pushed to inbound, carrying forward rs=roc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea57c1351cc

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3ea57c1351cc

Comment 6

[Yuan Pengfei]

VC2010 SP1 PGO build fails at json.cpp
I fix it by adding:
#include <stdio.h>

Comment 7

[Jonathan Kew [:jfkthame]]

(In reply to Yuan Pengfei from comment #6)
> VC2010 SP1 PGO build fails at json.cpp
> I fix it by adding:
> #include <stdio.h>

See bug 721466.